-
Notifications
You must be signed in to change notification settings - Fork 8.1k
Properly Expand Aliases to their actual ResolvedCommand #25763
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
test/powershell/Modules/Microsoft.PowerShell.Utility/Get-Alias.Tests.ps1
Outdated
Show resolved
Hide resolved
test/powershell/Modules/Microsoft.PowerShell.Utility/Get-Alias.Tests.ps1
Outdated
Show resolved
Hide resolved
test/powershell/Modules/Microsoft.PowerShell.Utility/Get-Alias.Tests.ps1
Outdated
Show resolved
Hide resolved
|
Thanks for the review & comments @iSazonov 👍🏻, will address them and make recommended changes shortly as they were inline with my own initial thoughts. |
|
Only reason this is marked for the Engine WG to review is due to the code path. Only other thing I am thinking should we have a test/ update this test for when you have
|
iSazonov
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
alias -> alias -> actual command
It is not related the PR. If you see real value for this please move to new PR.
test/powershell/Modules/Microsoft.PowerShell.Utility/Get-Alias.Tests.ps1
Show resolved
Hide resolved
|
The Engine WG was able to review this today & have signed off on adding this behaviour. We however would like additional code review to happen prior to merging. |
|
/azp run PowerShell-Windows-Packaging-CI, PowerShell-CI-linux-packaging |
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
|
📣 Hey @@kilasuit, how did we do? We would love to hear your feedback with the link below! 🗣️ |
PR Summary
Fix #25616
This fixes a long standing "quirk" in how aliased commands would show & fixes #25616 as suggested.
There are no changes to the Get-Alias Cmdlet itself, however does update logic used by this command via the
System.Management.Automation.AliasInfoobject and theDisplayNameScriptProperty.PR Context
This improves the user experience in understanding which alias maps to the resolved command to improve discoverability.
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright header