Fix infinite loop crash in variable type inference#25696
Merged
SeeminglyScience merged 1 commit intoPowerShell:masterfrom Jun 30, 2025
Merged
Fix infinite loop crash in variable type inference#25696SeeminglyScience merged 1 commit intoPowerShell:masterfrom
SeeminglyScience merged 1 commit intoPowerShell:masterfrom
Conversation
SeeminglyScience
approved these changes
Jun 30, 2025
Collaborator
SeeminglyScience
left a comment
There was a problem hiding this comment.
I remember seeing this ages ago when I was first learning about the AST and thinking "that can't possibly work correctly"
Thanks for the fix Martin! ❤️ LGTM!
Collaborator
|
/azp run PowerShell-CI-linux-packaging, PowerShell-Windows-Packaging-CI |
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
Contributor
|
📣 Hey @@MartinGC94, how did we do? We would love to hear your feedback with the link below! 🗣️ 🔗 https://aka.ms/PSRepoFeedback |
jobayer1V
added a commit
to jobayer1V/PowerShell
that referenced
this pull request
Jul 6, 2025
Fix infinite loop crash in variable type inference (PowerShell#25696)
jobayer1V
added a commit
to jobayer1V/PowerShell
that referenced
this pull request
Jul 12, 2025
jobayer1V
added a commit
to jobayer1V/PowerShell
that referenced
this pull request
Jul 12, 2025
Revert "Fix infinite loop crash in variable type inference (PowerShell#25696)"
Amro1984
pushed a commit
to Amro1984/PowerShell
that referenced
this pull request
Aug 12, 2025
SIRMARGIN
pushed a commit
to SIRMARGIN/PowerShell
that referenced
this pull request
Dec 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Fixes a crash caused by an incorrect check with the
IsWithinextension method. As the name suggests, it's supposed to check if an extent is within another extent but the check did not work properly. For example, suppose you have a PipelineAst like this:$Var1 | where {$true}and you want to check if$Var1IsWithin that ast, the check would correctly return true. However, if you formatted it like this:it would incorrectly return false because the end column of the PipelineAst is lower than the end column of the variable
$Var1.I've simplified the check to just look at the start and end offsets and it's now working as expected.
I'm not sure if a test is really needed since this is just a fix for an internal method that was simply wrong. But if it needs to be added I suppose I can just add a test like "It should not crash"
PR Context
Fixes #25694
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright header