Repository navigation
Make the interface IDeepCloneable internal - #25552
Conversation
|
Matthias Wolf (@mawosoft) please let me know if you any concerns. |
|
Dongbo Wang (@daxian-dbw) I don't have any concerns, it's just odd to pick one among many. None of these classes should probably be public. Also, nit: If you make it internal, you can remove the suppression attribute. |
|
The suppression attribute is removed. The main reason to make the |
Patrick Meinecke (SeeminglyScience)
left a comment
There was a problem hiding this comment.
LGTM
May not strictly be needed, but also doesn't need to be public so if we have the option to minimize confusion we might as well.
|
📣 Hey @Dongbo Wang (@daxian-dbw), how did we do? We would love to hear your feedback with the link below! 🗣️ 🔗 https://aka.ms/PSRepoFeedback |
PR Summary
This PR is a follow-up of the #25497.
The deep clone support in
Microsoft.Management.UI.Internalshould be made an implementation detail, so make theIDeepCloneableinterface internal instead.PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright header