Skip to content

Remove OnDeserialized and Serializable attributes from Microsoft.Management.UI.Internal project #25548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
daxian-dbw merged 2 commits into from
Jun 2, 2025
Merged

Remove OnDeserialized and Serializable attributes from Microsoft.Management.UI.Internal project #25548

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
302e774
Remove `OnDeserialized` and `Serializable` attributes
daxian-dbw May 13, 2025
c1adb15
Remove `[field: NonSerialized]`
daxian-dbw May 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion ...Management.UI.Internal/ManagementList/FilterCore/FilterRules/ComparableValueFilterRule.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ namespace Microsoft.Management.UI.Internal
/// The generic parameter.
/// </typeparam>
[System.Diagnostics.CodeAnalysis.SuppressMessage("Microsoft.MSInternal", "CA903:InternalNamespaceShouldNotContainPublicTypes")]
[Serializable]
public abstract class ComparableValueFilterRule<T> : FilterRule where T : IComparable
{
/// <summary>
Expand Down
1 change: 0 additions & 1 deletion ...ft.Management.UI.Internal/ManagementList/FilterCore/FilterRules/DoesNotEqualFilterRule.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ namespace Microsoft.Management.UI.Internal
/// The generic parameter.
/// </typeparam>
[System.Diagnostics.CodeAnalysis.SuppressMessage("Microsoft.MSInternal", "CA903:InternalNamespaceShouldNotContainPublicTypes")]
[Serializable]
public class DoesNotEqualFilterRule<T> : EqualsFilterRule<T> where T : IComparable
{
/// <summary>
Expand Down
1 change: 0 additions & 1 deletion ...icrosoft.Management.UI.Internal/ManagementList/FilterCore/FilterRules/EqualsFilterRule.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ namespace Microsoft.Management.UI.Internal
/// The generic parameter.
/// </typeparam>
[System.Diagnostics.CodeAnalysis.SuppressMessage("Microsoft.MSInternal", "CA903:InternalNamespaceShouldNotContainPublicTypes")]
[Serializable]
public class EqualsFilterRule<T> : SingleValueComparableValueFilterRule<T> where T : IComparable
{
/// <summary>
Expand Down
2 changes: 0 additions & 2 deletions src/Microsoft.Management.UI.Internal/ManagementList/FilterCore/FilterRules/FilterRule.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ namespace Microsoft.Management.UI.Internal
/// The base class for all filtering rules.
/// </summary>
[System.Diagnostics.CodeAnalysis.SuppressMessage("Microsoft.MSInternal", "CA903:InternalNamespaceShouldNotContainPublicTypes")]
[Serializable]
public abstract class FilterRule : IEvaluate, IDeepCloneable
{
/// <summary>
Expand Down Expand Up @@ -69,7 +68,6 @@ public object DeepClone()
/// <summary>
/// Occurs when the values of this rule changes.
/// </summary>
[field: NonSerialized]
public event EventHandler EvaluationResultInvalidated;

/// <summary>
Expand Down
8 changes: 0 additions & 8 deletions ...osoft.Management.UI.Internal/ManagementList/FilterCore/FilterRules/IsBetweenFilterRule.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ namespace Microsoft.Management.UI.Internal
/// The generic parameter.
/// </typeparam>
[System.Diagnostics.CodeAnalysis.SuppressMessage("Microsoft.MSInternal", "CA903:InternalNamespaceShouldNotContainPublicTypes")]
[Serializable]
public class IsBetweenFilterRule<T> : ComparableValueFilterRule<T> where T : IComparable
{
#region Properties
Expand Down Expand Up @@ -122,13 +121,6 @@ private void Value_PropertyChanged(object sender, PropertyChangedEventArgs e)
}
}

[OnDeserialized]
private void Initialize(StreamingContext context)
{
this.StartValue.PropertyChanged += this.Value_PropertyChanged;
this.EndValue.PropertyChanged += this.Value_PropertyChanged;
}

#endregion Value Change Handlers
}
}
1 change: 0 additions & 1 deletion ...crosoft.Management.UI.Internal/ManagementList/FilterCore/FilterRules/IsEmptyFilterRule.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ namespace Microsoft.Management.UI.Internal
/// is empty or not.
/// </summary>
[System.Diagnostics.CodeAnalysis.SuppressMessage("Microsoft.MSInternal", "CA903:InternalNamespaceShouldNotContainPublicTypes")]
[Serializable]
public class IsEmptyFilterRule : FilterRule
{
/// <summary>
Expand Down
1 change: 0 additions & 1 deletion ...t.Management.UI.Internal/ManagementList/FilterCore/FilterRules/IsGreaterThanFilterRule.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ namespace Microsoft.Management.UI.Internal
/// The generic parameter.
/// </typeparam>
[System.Diagnostics.CodeAnalysis.SuppressMessage("Microsoft.MSInternal", "CA903:InternalNamespaceShouldNotContainPublicTypes")]
[Serializable]
public class IsGreaterThanFilterRule<T> : SingleValueComparableValueFilterRule<T> where T : IComparable
{
/// <summary>
Expand Down
1 change: 0 additions & 1 deletion ...soft.Management.UI.Internal/ManagementList/FilterCore/FilterRules/IsLessThanFilterRule.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ namespace Microsoft.Management.UI.Internal
/// The generic parameter.
/// </typeparam>
[System.Diagnostics.CodeAnalysis.SuppressMessage("Microsoft.MSInternal", "CA903:InternalNamespaceShouldNotContainPublicTypes")]
[Serializable]
public class IsLessThanFilterRule<T> : SingleValueComparableValueFilterRule<T> where T : IComparable
{
/// <summary>
Expand Down
1 change: 0 additions & 1 deletion ...soft.Management.UI.Internal/ManagementList/FilterCore/FilterRules/IsNotEmptyFilterRule.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ namespace Microsoft.Management.UI.Internal
/// is empty or not.
/// </summary>
[System.Diagnostics.CodeAnalysis.SuppressMessage("Microsoft.MSInternal", "CA903:InternalNamespaceShouldNotContainPublicTypes")]
[Serializable]
public class IsNotEmptyFilterRule : IsEmptyFilterRule
{
/// <summary>
Expand Down
1 change: 0 additions & 1 deletion ....Management.UI.Internal/ManagementList/FilterCore/FilterRules/IsNotEmptyValidationRule.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ namespace Microsoft.Management.UI.Internal
/// The IsNotEmptyValidationRule checks a value to see if a value is not empty.
/// </summary>
[System.Diagnostics.CodeAnalysis.SuppressMessage("Microsoft.MSInternal", "CA903:InternalNamespaceShouldNotContainPublicTypes")]
[Serializable]
public class IsNotEmptyValidationRule : DataErrorInfoValidationRule
{
#region Properties
Expand Down
7 changes: 0 additions & 7 deletions ...ent.UI.Internal/ManagementList/FilterCore/FilterRules/PropertiesTextContainsFilterRule.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ namespace Microsoft.Management.UI.Internal
/// Represents a filter rule that searches for text within properties on an object.
/// </summary>
[System.Diagnostics.CodeAnalysis.SuppressMessage("Microsoft.MSInternal", "CA903:InternalNamespaceShouldNotContainPublicTypes")]
[Serializable]
public class PropertiesTextContainsFilterRule : TextFilterRule
{
private static readonly string TextContainsCharactersRegexPattern = "{0}";
Expand Down Expand Up @@ -131,11 +130,5 @@ private void PropertiesTextContainsFilterRule_EvaluationResultInvalidated(object
{
this.OnEvaluationResultInvalidated();
}

[OnDeserialized]
private void Initialize(StreamingContext context)
{
this.EvaluationResultInvalidated += this.PropertiesTextContainsFilterRule_EvaluationResultInvalidated;
}
}
}
1 change: 0 additions & 1 deletion ...ment.UI.Internal/ManagementList/FilterCore/FilterRules/PropertyValueSelectorFilterRule.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ namespace Microsoft.Management.UI.Internal
/// The generic parameter.
/// </typeparam>
[System.Diagnostics.CodeAnalysis.SuppressMessage("Microsoft.MSInternal", "CA903:InternalNamespaceShouldNotContainPublicTypes")]
[Serializable]
public class PropertyValueSelectorFilterRule<T> : SelectorFilterRule where T : IComparable
{
#region Properties
Expand Down
8 changes: 0 additions & 8 deletions ...rosoft.Management.UI.Internal/ManagementList/FilterCore/FilterRules/SelectorFilterRule.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ namespace Microsoft.Management.UI.Internal
/// The SelectorFilterRule represents a rule composed of other rules.
/// </summary>
[System.Diagnostics.CodeAnalysis.SuppressMessage("Microsoft.MSInternal", "CA903:InternalNamespaceShouldNotContainPublicTypes")]
[Serializable]
public class SelectorFilterRule : FilterRule
{
#region Properties
Expand Down Expand Up @@ -113,13 +112,6 @@ private void SelectedValue_EvaluationResultInvalidated(object sender, EventArgs

#region Private Methods

[OnDeserialized]
private void Initialize(StreamingContext context)
{
this.AvailableRules.SelectedValueChanged += this.AvailableRules_SelectedValueChanged;
this.AvailableRules.SelectedValue.EvaluationResultInvalidated += this.SelectedValue_EvaluationResultInvalidated;
}

private void AvailableRules_SelectedValueChanged(object sender, PropertyChangedEventArgs<FilterRule> e)
{
this.OnSelectedValueChanged(e.OldValue, e.NewValue);
Expand Down
7 changes: 0 additions & 7 deletions ...UI.Internal/ManagementList/FilterCore/FilterRules/SingleValueComparableValueFilterRule.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ namespace Microsoft.Management.UI.Internal
/// </summary>
/// <typeparam name="T">The generic parameter.</typeparam>
[System.Diagnostics.CodeAnalysis.SuppressMessage("Microsoft.MSInternal", "CA903:InternalNamespaceShouldNotContainPublicTypes")]
[Serializable]
public abstract class SingleValueComparableValueFilterRule<T> : ComparableValueFilterRule<T> where T : IComparable
{
#region Properties
Expand Down Expand Up @@ -72,11 +71,5 @@ private void Value_PropertyChanged(object sender, PropertyChangedEventArgs e)
this.NotifyEvaluationResultInvalidated();
}
}

[OnDeserialized]
private void Initialize(StreamingContext context)
{
this.Value.PropertyChanged += this.Value_PropertyChanged;
}
}
}
1 change: 0 additions & 1 deletion ...ft.Management.UI.Internal/ManagementList/FilterCore/FilterRules/TextContainsFilterRule.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ namespace Microsoft.Management.UI.Internal
/// check if it is contains the rule's value within it.
/// </summary>
[System.Diagnostics.CodeAnalysis.SuppressMessage("Microsoft.MSInternal", "CA903:InternalNamespaceShouldNotContainPublicTypes")]
[Serializable]
public class TextContainsFilterRule : TextFilterRule
{
private static readonly string TextContainsCharactersRegexPattern = "{0}";
Expand Down
1 change: 0 additions & 1 deletion ...agement.UI.Internal/ManagementList/FilterCore/FilterRules/TextDoesNotContainFilterRule.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ namespace Microsoft.Management.UI.Internal
/// check if it is does not contain the rule's value within it.
/// </summary>
[System.Diagnostics.CodeAnalysis.SuppressMessage("Microsoft.MSInternal", "CA903:InternalNamespaceShouldNotContainPublicTypes")]
[Serializable]
public class TextDoesNotContainFilterRule : TextContainsFilterRule
{
/// <summary>
Expand Down
1 change: 0 additions & 1 deletion ...anagement.UI.Internal/ManagementList/FilterCore/FilterRules/TextDoesNotEqualFilterRule.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ namespace Microsoft.Management.UI.Internal
/// check if it is not equal to the rule's value.
/// </summary>
[System.Diagnostics.CodeAnalysis.SuppressMessage("Microsoft.MSInternal", "CA903:InternalNamespaceShouldNotContainPublicTypes")]
[Serializable]
public class TextDoesNotEqualFilterRule : TextEqualsFilterRule
{
/// <summary>
Expand Down
1 change: 0 additions & 1 deletion ...ft.Management.UI.Internal/ManagementList/FilterCore/FilterRules/TextEndsWithFilterRule.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ namespace Microsoft.Management.UI.Internal
/// check if it ends with the rule's value.
/// </summary>
[System.Diagnostics.CodeAnalysis.SuppressMessage("Microsoft.MSInternal", "CA903:InternalNamespaceShouldNotContainPublicTypes")]
[Serializable]
public class TextEndsWithFilterRule : TextFilterRule
{
private static readonly string TextEndsWithCharactersRegexPattern = "{0}$";
Expand Down
1 change: 0 additions & 1 deletion ...soft.Management.UI.Internal/ManagementList/FilterCore/FilterRules/TextEqualsFilterRule.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ namespace Microsoft.Management.UI.Internal
/// check if it is equal to the rule's value.
/// </summary>
[System.Diagnostics.CodeAnalysis.SuppressMessage("Microsoft.MSInternal", "CA903:InternalNamespaceShouldNotContainPublicTypes")]
[Serializable]
public class TextEqualsFilterRule : TextFilterRule
{
private static readonly string TextEqualsCharactersRegexPattern = "^{0}$";
Expand Down
1 change: 0 additions & 1 deletion src/Microsoft.Management.UI.Internal/ManagementList/FilterCore/FilterRules/TextFilterRule.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ namespace Microsoft.Management.UI.Internal
/// evaluating string operations.
/// </summary>
[System.Diagnostics.CodeAnalysis.SuppressMessage("Microsoft.MSInternal", "CA903:InternalNamespaceShouldNotContainPublicTypes")]
[Serializable]
public abstract class TextFilterRule : SingleValueComparableValueFilterRule<string>
{
/// <summary>
Expand Down
1 change: 0 additions & 1 deletion ....Management.UI.Internal/ManagementList/FilterCore/FilterRules/TextStartsWithFilterRule.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ namespace Microsoft.Management.UI.Internal
/// check if it starts with the rule's value.
/// </summary>
[System.Diagnostics.CodeAnalysis.SuppressMessage("Microsoft.MSInternal", "CA903:InternalNamespaceShouldNotContainPublicTypes")]
[Serializable]
public class TextStartsWithFilterRule : TextFilterRule
{
private static readonly string TextStartsWithCharactersRegexPattern = "^{0}";
Expand Down
2 changes: 0 additions & 2 deletions src/Microsoft.Management.UI.Internal/ManagementList/FilterCore/ValidatingSelectorValue.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ namespace Microsoft.Management.UI.Internal
/// The generic parameter.
/// </typeparam>
[System.Diagnostics.CodeAnalysis.SuppressMessage("Microsoft.MSInternal", "CA903:InternalNamespaceShouldNotContainPublicTypes")]
[Serializable]
public class ValidatingSelectorValue<T> : ValidatingValueBase
{
/// <summary>
Expand Down Expand Up @@ -174,7 +173,6 @@ public IValueConverter DisplayNameConverter
/// <summary>
/// Notifies listeners that the selected value has changed.
/// </summary>
[field: NonSerialized]
public event EventHandler<PropertyChangedEventArgs<T>> SelectedValueChanged;

#endregion Events
Expand Down
1 change: 0 additions & 1 deletion src/Microsoft.Management.UI.Internal/ManagementList/FilterCore/ValidatingValue.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@ namespace Microsoft.Management.UI.Internal
/// The generic parameter.
/// </typeparam>
[System.Diagnostics.CodeAnalysis.SuppressMessage("Microsoft.MSInternal", "CA903:InternalNamespaceShouldNotContainPublicTypes")]
[Serializable]
public class ValidatingValue<T> : ValidatingValueBase
{
/// <summary>
Expand Down
3 changes: 0 additions & 3 deletions src/Microsoft.Management.UI.Internal/ManagementList/FilterCore/ValidatingValueBase.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@ namespace Microsoft.Management.UI.Internal
/// classes to support validation via the IDataErrorInfo interface.
/// </summary>
[System.Diagnostics.CodeAnalysis.SuppressMessage("Microsoft.MSInternal", "CA903:InternalNamespaceShouldNotContainPublicTypes")]
[Serializable]
public abstract class ValidatingValueBase : IDataErrorInfo, INotifyPropertyChanged, IDeepCloneable
{
/// <summary>
Expand Down Expand Up @@ -47,7 +46,6 @@ protected ValidatingValueBase(ValidatingValueBase source)
private ReadOnlyCollection<DataErrorInfoValidationRule> readonlyValidationRules;
private bool isValidationRulesCollectionDirty = true;

[field: NonSerialized]
private DataErrorInfoValidationResult cachedValidationResult;

/// <summary>
Expand Down Expand Up @@ -141,7 +139,6 @@ public string Error
/// <remarks>
/// The listeners attached to this event are not serialized.
/// </remarks>
[field: NonSerialized]
public event PropertyChangedEventHandler PropertyChanged;

#endregion PropertyChanged
Expand Down
1 change: 0 additions & 1 deletion ...ment.UI.Internal/ManagementList/FilterCore/ValidationRules/DataErrorInfoValidationRule.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ namespace Microsoft.Management.UI.Internal
/// Provides a way to create a custom rule in order to check the validity of user input.
/// </summary>
[System.Diagnostics.CodeAnalysis.SuppressMessage("Microsoft.MSInternal", "CA903:InternalNamespaceShouldNotContainPublicTypes")]
[Serializable]
public abstract class DataErrorInfoValidationRule : IDeepCloneable
{
/// <summary>
Expand Down
1 change: 0 additions & 1 deletion ...Management.UI.Internal/ManagementList/FilterProviders/FilterRuleToDisplayNameConverter.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ namespace Microsoft.Management.UI.Internal
/// a FilterRule value to its DisplayName.
/// </summary>
[System.Diagnostics.CodeAnalysis.SuppressMessage("Microsoft.MSInternal", "CA903:InternalNamespaceShouldNotContainPublicTypes")]
[Serializable]
public class FilterRuleToDisplayNameConverter : IValueConverter
{
/// <summary>
Expand Down
1 change: 0 additions & 1 deletion ...oft.Management.UI.Internal/ManagementList/ManagementList/ManagementListStateDescriptor.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ namespace Microsoft.Management.UI.Internal
/// Allows the state of the ManagementList to be saved and restored.
/// </summary>
[SuppressMessage("Microsoft.MSInternal", "CA903:InternalNamespaceShouldNotContainPublicTypes")]
[Serializable]
public class ManagementListStateDescriptor : StateDescriptor<ManagementList>
{
#region Fields
Expand Down
1 change: 0 additions & 1 deletion src/powershell-win-core/powershell-win-core.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@
<ApplicationManifest>..\..\assets\pwsh.manifest</ApplicationManifest>
<TargetPlatformIdentifier>Windows</TargetPlatformIdentifier>
<TargetPlatformVersion>8.0</TargetPlatformVersion>
<EnableUnsafeBinaryFormatterSerialization>true</EnableUnsafeBinaryFormatterSerialization>
</PropertyGroup>

<Import Project="Sdk.props" Sdk="Microsoft.NET.Sdk" />
Expand Down
Loading