Repository navigation
Remove OnDeserialized and Serializable attributes from Microsoft.Management.UI.Internal project - #25548
Merged
Conversation
Dongbo Wang (daxian-dbw)
requested review from
a team and
Justin Chung (jshigetomi)
as code owners
May 13, 2025 05:20
Collaborator
|
Dongbo Wang (@daxian-dbw) There are three |
Ilya (iSazonov)
approved these changes
May 13, 2025
Patrick Meinecke (SeeminglyScience)
approved these changes
Jun 2, 2025
Patrick Meinecke (SeeminglyScience)
left a comment
Contributor
There was a problem hiding this comment.
LGTM!
Contributor
|
📣 Hey @Dongbo Wang (@daxian-dbw), how did we do? We would love to hear your feedback with the link below! 🗣️ 🔗 https://aka.ms/PSRepoFeedback |
4 of 9 tasks
PowerShell Team Bot (pwshBot)
pushed a commit
to pwshBot/PowerShell
that referenced
this pull request
Jun 4, 2025
9 tasks
PowerShell Team Bot (pwshBot)
pushed a commit
to pwshBot/PowerShell
that referenced
this pull request
Aug 6, 2025
….Management.UI.Internal` project (PowerShell#25548) Also removed `EnableUnsafeBinaryFormatterSerialization` property from `powershell-win-core.csproj` to disable the use of `BinaryFormatter`.
9 tasks
SIRMARGIN
pushed a commit
to SIRMARGIN/PowerShell
that referenced
this pull request
Dec 12, 2025
….Management.UI.Internal` project (PowerShell#25548) Also removed `EnableUnsafeBinaryFormatterSerialization` property from `powershell-win-core.csproj` to disable the use of `BinaryFormatter`.
Thatgfsj (Thatgfsj)
pushed a commit
to Thatgfsj-contribs/PowerShell
that referenced
this pull request
Aug 6, 2026
….Management.UI.Internal` project (PowerShell#25548) Also removed `EnableUnsafeBinaryFormatterSerialization` property from `powershell-win-core.csproj` to disable the use of `BinaryFormatter`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
This PR is a follow-up of the #25497, to clean up the
[Serializable]and[OnDeserialized]attributes, as well as theEnableUnsafeBinaryFormatterSerializationproperty frompowershell-win-core.csproj(to disable the use ofBinaryFormatter).PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright header