Skip to content

Remove OnDeserialized and Serializable attributes from Microsoft.Management.UI.Internal project - #25548

Merged
Dongbo Wang (daxian-dbw) merged 2 commits into
PowerShell:masterfrom
daxian-dbw:cleanup
Jun 2, 2025
Merged

Dongbo Wang (daxian-dbw) merged 2 commits into
PowerShell:masterfrom
daxian-dbw:cleanup

Conversation

@daxian-dbw

@daxian-dbw Dongbo Wang (daxian-dbw) commented May 13, 2025 •

Copy link
Copy Markdown
Member

PR Summary

This PR is a follow-up of the #25497, to clean up the [Serializable] and [OnDeserialized] attributes, as well as the EnableUnsafeBinaryFormatterSerialization property from powershell-win-core.csproj (to disable the use of BinaryFormatter).

PR Checklist

@daxian-dbw Dongbo Wang (daxian-dbw) added the CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log label May 13, 2025
@iSazonov

Copy link
Copy Markdown
Collaborator

Dongbo Wang (@daxian-dbw) There are three [field: NonSerialized].

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@daxian-dbw
Dongbo Wang (daxian-dbw) merged commit 625da6f into PowerShell:master Jun 2, 2025
@daxian-dbw
Dongbo Wang (daxian-dbw) deleted the cleanup branch June 2, 2025 22:16
@daxian-dbw Dongbo Wang (daxian-dbw) removed the Review - Needed The PR is being reviewed label Jun 2, 2025
@microsoft-github-policy-service

microsoft-github-policy-service Bot commented Jun 2, 2025 •

Copy link
Copy Markdown
Contributor

📣 Hey @Dongbo Wang (@daxian-dbw), how did we do? We would love to hear your feedback with the link below! 🗣️

🔗 https://aka.ms/PSRepoFeedback

PowerShell Team Bot (pwshBot) pushed a commit to pwshBot/PowerShell that referenced this pull request Aug 6, 2025
….Management.UI.Internal` project (PowerShell#25548)

Also removed `EnableUnsafeBinaryFormatterSerialization` property from `powershell-win-core.csproj` to disable the use of `BinaryFormatter`.
SIRMARGIN pushed a commit to SIRMARGIN/PowerShell that referenced this pull request Dec 12, 2025
….Management.UI.Internal` project (PowerShell#25548)

Also removed `EnableUnsafeBinaryFormatterSerialization` property from `powershell-win-core.csproj` to disable the use of `BinaryFormatter`.
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
….Management.UI.Internal` project (PowerShell#25548)

Also removed `EnableUnsafeBinaryFormatterSerialization` property from `powershell-win-core.csproj` to disable the use of `BinaryFormatter`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log

Projects

Development

Successfully merging this pull request may close these issues.

3 participants