Tests for BigInteger parsing across cultures (#25396)#25463
Closed
AbishekPonmudi wants to merge 2 commits intoPowerShell:masterfrom
Closed
Tests for BigInteger parsing across cultures (#25396)#25463AbishekPonmudi wants to merge 2 commits intoPowerShell:masterfrom
AbishekPonmudi wants to merge 2 commits intoPowerShell:masterfrom
Conversation
7 tasks
iSazonov
reviewed
Apr 28, 2025
| [System.Globalization.CultureInfo]::CurrentCulture = [System.Globalization.CultureInfo]::GetCultureInfo("en-US") | ||
| $formattedNumber = "1,000" | ||
| $result = 0 | ||
| $parsed = [bigint]::TryParse($formattedNumber, [System.Globalization.NumberStyles]::Number, [System.Globalization.CultureInfo]::CurrentCulture, [ref]$result) |
Collaborator
There was a problem hiding this comment.
We have no need to test standard .Net methods.
Contributor
|
📣 Hey @@AbishekPonmudi, how did we do? We would love to hear your feedback with the link below! 🗣️ 🔗 https://aka.ms/PSRepoFeedback |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tests for BigInteger Parsing Across Cultures (#25396)
Overview
This PR adds unit tests for verifying
BigIntegerparsing across different cultures and number formats. The tests ensure PowerShell correctly converts numbers with various thousands separators, including:1,000) → Used inen-US,hi-IN1 000) → Used inru-RU,fr-FR,sv-SE1,00,000) → Used inhi-INThe tests dynamically fetch the correct
NumberGroupSeparatorbased on the current locale to prevent parsing errors seen in older PowerShell versions.Changes Included
test/powershell/engine/BigIntegerCultureHandling.Tests.ps1en-US,hi-IN,fr-FR, etc.)Related PRs
This PR adds necessary tests for PR #25396, ensuring full validation of numeric parsing behavior.