Skip to content

Fix infinite loop in variable type inference #25206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iSazonov merged 4 commits into from
Mar 26, 2025
Merged

Fix infinite loop in variable type inference #25206

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7b107fb
Fix infinite loop in variable type inference
MartinGC94 Mar 20, 2025
d2c523e
Also handle SetLastAssignmentType
MartinGC94 Mar 21, 2025
aced779
Revert "Also handle SetLastAssignmentType"
MartinGC94 Mar 24, 2025
c596eae
Add comment
MartinGC94 Mar 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/System.Management.Automation/engine/parser/TypeInferenceVisitor.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2930,8 +2930,10 @@ private sealed class VariableAssignmentVisitor : AstVisitor2

private void SetLastAssignment(Ast ast, bool enumerate = false, bool redirectionAssignment = false)
{
if (LastAssignmentOffset < ast.Extent.StartOffset)
if (LastAssignmentOffset < ast.Extent.StartOffset && !VariableTarget.Extent.IsWithin(ast.Extent))
{
// If the variable we are inferring the value of is inside this assignment then the assignment is invalid
// For example: $x = Get-Random; $x = $x.Where{$_.<Tab>} here the value should be inferred based on Get-Random and not $x = $x...
ClearAssignmentData();
LastAssignment = ast;
EnumerateAssignment = enumerate;
Expand Down
6 changes: 6 additions & 0 deletions test/powershell/engine/Api/TypeInference.Tests.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1197,6 +1197,12 @@ Describe "Type inference Tests" -tags "CI" {
$res.Name | Should -Be System.String
}

It 'Ignores the last assignment when a variable is reused' {
$variableAst = { $x = New-Guid; $x = $x.Where{$_} }.Ast.FindAll({ param($a) $a -is [Language.VariableExpressionAst] }, $true) | select -Last 1
$res = [AstTypeInference]::InferTypeOf($variableAst)
$res.Name | Should -Be System.Guid
}

$catchClauseTypes = @(
@{ Type = 'System.ArgumentException' }
@{ Type = 'System.ArgumentNullException' }
Expand Down
Loading