Update pipeline to use CFS when using Install-Module#25123
Closed
jshigetomi wants to merge 12 commits intorelease/v7.4from
Closed
Update pipeline to use CFS when using Install-Module#25123jshigetomi wants to merge 12 commits intorelease/v7.4from
jshigetomi wants to merge 12 commits intorelease/v7.4from
Conversation
added 3 commits
March 4, 2025 14:45
Collaborator
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
andyleejordan
requested changes
Mar 5, 2025
Member
andyleejordan
left a comment
andyleejordan
left a comment
There was a problem hiding this comment.
What's the explanation for all the Uninstall-AzureRm calls?
| Get-PackageProvider -Name NuGet -ForceBootstrap | ||
| Install-Module -Name Az.Storage -Verbose -Force -AllowClobber | ||
| ./tools/installPSResource.ps1 -PSRepository CFS | ||
| Uninstall-AzureRm -Verbose |
Member
There was a problem hiding this comment.
So we confirmed we still need to run Uninstall-AzureRm, and specifically after installing Az.Accounts and Az.Storage?
Collaborator
Author
There was a problem hiding this comment.
@TravisEz13 Can you explain why we need to do this?
microsoft-github-policy-service
bot
added
the
Waiting on Author
21 tasks
Co-authored-by: Andy Jordan <2226434+andyleejordan@users.noreply.github.com>
Co-authored-by: Andy Jordan <2226434+andyleejordan@users.noreply.github.com>
Co-authored-by: Andy Jordan <2226434+andyleejordan@users.noreply.github.com>
microsoft-github-policy-service
bot
removed
the
Waiting on Author
Co-authored-by: Andy Jordan <2226434+andyleejordan@users.noreply.github.com>
Co-authored-by: Andy Jordan <2226434+andyleejordan@users.noreply.github.com>
Co-authored-by: Andy Jordan <2226434+andyleejordan@users.noreply.github.com>
TravisEz13
added
the
CL-BuildPackaging
andyleejordan
approved these changes
Mar 12, 2025
Member
andyleejordan
left a comment
andyleejordan
left a comment
There was a problem hiding this comment.
I know the other PR is what did this, and this is just backporting, but can I say I love seeing a PR that deletes 100+ lines of code from a pipeline? 🥳
microsoft-github-policy-service
bot
added
the
Review - Needed
Contributor
|
📣 Hey @@jshigetomi, how did we do? We would love to hear your feedback with the link below! 🗣️ 🔗 https://aka.ms/PSRepoFeedback |
microsoft-github-policy-service
bot
removed
the
Review - Needed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
This pull request includes several updates to the pipeline configuration files and the addition of a new script for installing PowerShell resources. The main changes focus on updating the installation method for PowerShell modules and modifying the source of a coordinated build pipeline.
Changes to installation methods:
.pipelines/templates/checkAzureContainer.yml: Replaced inline PowerShell commands with./tools/installPSResource.ps1script for installing PowerShell modules..pipelines/templates/compliance/apiscan.yml: Replaced inline PowerShell commands with./tools/installPSResource.ps1script for installing PowerShell modules..pipelines/templates/compliance/generateNotice.yml: Replaced inline PowerShell commands with./tools/installPSResource.ps1script for installing PowerShell modules..pipelines/templates/release-MakeBlobPublic.yml,.pipelines/templates/release-create-msix.yml,.pipelines/templates/release-upload-buildinfo.yml,.pipelines/templates/release-validate-packagenames.yml,.pipelines/templates/uploadToAzure.yml: Replaced inline PowerShell commands with./tools/installPSResource.ps1script for installing PowerShell modules. [1] [2] [3] [4] [5] [6]Changes to build pipeline source:
.pipelines/PowerShell-Packages-Official.yml: Updated the source of the coordinated build pipeline from 'PowerShell-Coordinated Packages-Official' to 'PowerShell-Coordinated Binaries-Official'.Addition of new script:
tools/installPSResources.ps1: Added a new script for installing PowerShell resources from specified repositories, including handling for a specific repository bug.PR Context
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.- [ ] Issue filed:
(which runs in a different PS Host).