Make Component Manifest Updater use neutral target in addition to RID target#25094
Merged
TravisEz13 merged 1 commit intoPowerShell:masterfrom Feb 26, 2025
Merged
Conversation
Member
Author
|
/azp run PowerShell-CI-linux-packaging, PowerShell-Windows-Packaging-CI |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
|
📣 Hey @TravisEz13, how did we do? We would love to hear your feedback with the link below! 🗣️ 🔗 https://aka.ms/PSRepoFeedback |
TravisEz13
added a commit
to TravisEz13/PowerShell
that referenced
this pull request
Feb 26, 2025
pwshBot
pushed a commit
to pwshBot/PowerShell
that referenced
this pull request
Apr 11, 2025
Merged
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
This pull request includes several changes to the
Get-CGRegistrationsfunction in thetools/findMissingNotices.ps1file to improve the handling of target paths and to skip specific names during TPN (Third Party Notices) generation.Improvements to target path handling:
$neutralTargetfor each runtime pattern to handle neutral targets.Get-ChildItemcommand to include items from the$neutralTargetpath.Enhancements to TPN generation:
$skipNamesarray.$skipNamesarray and included verbose logging for skipped names. [1] [2]PR Context
.NET started using multiple targets in .NET 8. This makes this script miss some components.
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.- [ ] Issue filed:
(which runs in a different PS Host).