Skip to content

Add support <Suppress> in Get-WinEvent -FilterHashtable#2506

Merged
mirichmo merged 2 commits into
PowerShell:masterfrom
iSazonov:suspendgetwinevent
Oct 27, 2016
Merged

Add support <Suppress> in Get-WinEvent -FilterHashtable#2506
mirichmo merged 2 commits into
PowerShell:masterfrom
iSazonov:suspendgetwinevent

Conversation

@iSazonov

@iSazonov iSazonov commented Oct 19, 2016 •
edited
Loading

Copy link
Copy Markdown
Collaborator
  1. Add support Suppress
  2. Refacrtoring BuildStructuredQueryFromHashTable() to use StringBuilder
  3. Add tests

Close #2402

@msftclas

msftclas commented Oct 19, 2016

Copy link
Copy Markdown

Hi @iSazonov, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!

The agreement was validated by Microsoft and real humans are currently evaluating your PR.

TTYL, MSBOT;

@iSazonov

iSazonov commented Oct 20, 2016

Copy link
Copy Markdown
Collaborator Author

"Changelog Needed" Is it for me?
And what about changes in help documentation?

@lzybkr

lzybkr commented Oct 20, 2016

Copy link
Copy Markdown
Contributor

Regarding Changelog Needed, see https://github.com/PowerShell/PowerShell/blob/master/docs/maintainers/issue-management.md

@iSazonov

iSazonov commented Oct 20, 2016

Copy link
Copy Markdown
Collaborator Author

My question was: who makes adding into changelog - I or maintainers? It is not clear from the documentation.

@iSazonov
Add support <Suppress> in Get-WinEvent -FilterHashtable
7dd5774 
1. Add support <Suppress>
2. Refacrtoring BuildStructuredQueryFromHashTable() to use StringBuilder
3. Add tests
@iSazonov

iSazonov commented Oct 20, 2016

Copy link
Copy Markdown
Collaborator Author

Add record to the changelog.

@lzybkr

lzybkr commented Oct 20, 2016

Copy link
Copy Markdown
Contributor

It doesn't matter who updates the change log, just that it happens. It is of course appreciated if you do.

@iSazonov

iSazonov commented Oct 20, 2016

Copy link
Copy Markdown
Collaborator Author

Thanks @lzybkr. I did.

@mirichmo

mirichmo commented Oct 20, 2016

Copy link
Copy Markdown
Member

@PaulHigin Please take a look

@mirichmo

mirichmo commented Oct 21, 2016

Copy link
Copy Markdown
Member

@JamesWTruher Paul is busy. Please review

@JamesWTruher

JamesWTruher commented Oct 27, 2016

Copy link
Copy Markdown
Collaborator

:shipit:

@mirichmo mirichmo merged commit baeec06 into PowerShell:master Oct 27, 2016
@mirichmo mirichmo added this to the 6.0.0-alpha.12 milestone Oct 27, 2016
@iSazonov

iSazonov commented Oct 28, 2016

Copy link
Copy Markdown
Collaborator Author

@JamesWTruher @lzybkr Thanks for review and support!

@iSazonov iSazonov deleted the suspendgetwinevent branch October 28, 2016 03:56
@iSazonov iSazonov mentioned this pull request Oct 31, 2016
Closed
@iSazonov iSazonov added the Documentation Needed in this repo Documentation is needed in this repo label Jun 17, 2017
@joeyaiello joeyaiello mentioned this pull request Oct 15, 2018
Closed
@joeyaiello joeyaiello removed Documentation Needed in this repo Documentation is needed in this repo labels Oct 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

6.0.0-alpha.12

Development

Successfully merging this pull request may close these issues.

7 participants

@iSazonov @msftclas @lzybkr @mirichmo @JamesWTruher @daxian-dbw @joeyaiello