Skip to content

Enable SA1411: Attribute constructor should not use unnecessary parenthesis#24969

Open
xtqqczze wants to merge 1 commit intoPowerShell:masterfrom
xtqqczze:SA1411
Open

Enable SA1411: Attribute constructor should not use unnecessary parenthesis#24969
xtqqczze wants to merge 1 commit intoPowerShell:masterfrom
xtqqczze:SA1411

Conversation

@xtqqczze
Copy link
Contributor

@xtqqczze xtqqczze commented Feb 7, 2025 •
edited
Loading

@xtqqczze xtqqczze mentioned this pull request Feb 7, 2025
Merged
@iSazonov

This comment was marked as outdated.

Sign in to view
@iSazonov iSazonov added the CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log label Feb 8, 2025
@azure-pipelines

This comment was marked as outdated.

Sign in to view
@iSazonov
Copy link
Collaborator

iSazonov commented Feb 8, 2025 •
edited by unfurl-links bot
Loading

@xtqqczze Could you please migrate our Settings.StyleCop rules to .globalconfig file in follow PRs (one rule by one).

From https://github.com/DotNetAnalyzers/StyleCopAnalyzers

Settings.StyleCop is not supported, but a stylecop.json file may be used to customize the behavior of certain rules. See Configuration.md for more information.

GitHub
An implementation of StyleCop rules using the .NET Compiler Platform - DotNetAnalyzers/StyleCopAnalyzers

@iSazonov iSazonov self-assigned this Feb 8, 2025
iSazonov
iSazonov previously approved these changes Feb 8, 2025
View reviewed changes
@iSazonov iSazonov enabled auto-merge (squash) February 8, 2025 06:26
@iSazonov iSazonov disabled auto-merge February 8, 2025 06:26
@iSazonov iSazonov self-requested a review February 8, 2025 06:27
@iSazonov
Copy link
Collaborator

iSazonov commented Feb 8, 2025

Not all SA1411 fixed.

@xtqqczze xtqqczze requested a review from daxian-dbw as a code owner February 8, 2025 10:56
@xtqqczze xtqqczze mentioned this pull request Feb 8, 2025
Open
@iSazonov
Copy link
Collaborator

iSazonov commented Feb 8, 2025

/azp run

@azure-pipelines
Copy link

azure-pipelines bot commented Feb 8, 2025

Azure Pipelines successfully started running 2 pipeline(s).

iSazonov
iSazonov reviewed Feb 8, 2025
View reviewed changes
@xtqqczze
Copy link
Contributor Author

xtqqczze commented Feb 11, 2025

@iSazonov can we merge?

@iSazonov
Copy link
Collaborator

iSazonov commented Feb 11, 2025

can we merge?

As I said we should use .editorconfig.

@xtqqczze xtqqczze changed the title Enable SA1411: Attribute constructor should not use unnecessary parenthesis Enable SA1411: Attribute constructor should not use unnecessary parenthesis Feb 15, 2025
@xtqqczze
Copy link
Contributor Author

xtqqczze commented Feb 15, 2025

As I said we should use .editorconfig.

Changes to analyzer configuration should be in separate PR

@microsoft-github-policy-service microsoft-github-policy-service bot added the Review - Needed The PR is being reviewed label Feb 22, 2025
@iSazonov iSazonov self-requested a review February 25, 2025 16:10
iSazonov
iSazonov previously approved these changes Apr 23, 2025
View reviewed changes
@iSazonov iSazonov self-requested a review April 23, 2025 11:34
@iSazonov iSazonov removed their assignment May 28, 2025
@microsoft-github-policy-service microsoft-github-policy-service bot removed the Review - Needed The PR is being reviewed label May 28, 2025
@microsoft-github-policy-service microsoft-github-policy-service bot added the Review - Needed The PR is being reviewed label Jun 4, 2025
@xtqqczze
Copy link
Contributor Author

xtqqczze commented Oct 8, 2025

@iSazonov Can we merge as is?

@iSazonov
Copy link
Collaborator

iSazonov commented Oct 9, 2025

@xtqqczze We need approving by code owners.

@microsoft-github-policy-service microsoft-github-policy-service bot removed the Review - Needed The PR is being reviewed label Oct 9, 2025
@microsoft-github-policy-service microsoft-github-policy-service bot added the Review - Needed The PR is being reviewed label Oct 16, 2025
@microsoft-github-policy-service
Copy link
Contributor

microsoft-github-policy-service bot commented Oct 16, 2025

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adityapatwardhan adityapatwardhan Awaiting requested review from adityapatwardhan adityapatwardhan is a code owner

@daxian-dbw daxian-dbw Awaiting requested review from daxian-dbw daxian-dbw is a code owner

@iSazonov iSazonov Awaiting requested review from iSazonov

@TravisEz13 TravisEz13 Awaiting requested review from TravisEz13 TravisEz13 is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log Review - Needed The PR is being reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@xtqqczze @iSazonov