Skip to content

Fix Start-Transcript error when $Transcript is a PSObject wrapped string #24963

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iSazonov merged 2 commits into from
Feb 7, 2025
Merged

Fix Start-Transcript error when $Transcript is a PSObject wrapped string #24963

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
71b98b6
Fix Start-Transcript exception when $Transcript is a PSObject wrapped…
kborowinski Feb 6, 2025
d8120ae
Refactor test to use ValidateTranscription function
kborowinski Feb 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Microsoft.PowerShell.ConsoleHost/host/msh/StartTranscriptCmdlet.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,7 +177,7 @@ protected override void BeginProcessing()
}
else
{
_outFilename = (string)value;
_outFilename = (string)PSObject.Base(value);
}
}

Expand Down
5 changes: 5 additions & 0 deletions test/powershell/Modules/Microsoft.Powershell.Host/Start-Transcript.Tests.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,11 @@ Describe "Start-Transcript, Stop-Transcript tests" -tags "CI" {
$outputFilePath = Join-Path $TestDrive "PowerShell_transcript*"
ValidateTranscription -scriptToExecute $script -outputFilePath $outputFilePath
}
It "Should create Transcript file with 'Transcript' preference variable" {
# Casting to PSObject is necessary because Set-Variable does not automatically wrap the value in a PSObject
$script = "Set-Variable -Scope Global -Name Transcript -Value ([PSObject]'$transcriptFilePath'); Start-Transcript"
ValidateTranscription -scriptToExecute $script -outputFilePath $transcriptFilePath
}
It "Should Append Transcript data in existing file if 'Append' parameter is used with Path parameter" {
$script = "Start-Transcript -path $transcriptFilePath -Append"
ValidateTranscription -scriptToExecute $script -outputFilePath $transcriptFilePath -append
Expand Down
Loading