Skip to content

add a timeout to test-connection #2492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lzybkr merged 1 commit into from
Feb 23, 2017
Merged

add a timeout to test-connection #2492

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions src/Microsoft.PowerShell.Commands.Management/commands/management/Computer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,6 +127,14 @@ public class TestConnectionCommand : PSCmdlet
[ValidateRange((int)0, (int)65500)]
public Int32 BufferSize { get; set; } = 32;

/// <summary>
/// The following is the definition of the input parameter "TimeOut".
/// Time-out value in milliseconds. If a response is not received in this time, no response is assumed. The default is 1000 milliseconds.
/// </summary>
[Parameter]
[ValidateRange((int)1, Int32.MaxValue)]
Copy link
Contributor

@lzybkr lzybkr Oct 20, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've never liked this use of ValidateRange - it seems like we should have ValidatePositive and ValidateNonNegative attributes.

public Int32 TimeOut { get; set; } = 1000;

/// <summary>
/// The following is the definition of the input parameter "ComputerName".
/// Value of the address requested. The form of the value can be either the
Expand Down Expand Up @@ -399,6 +407,9 @@ private string QueryString(string[] machinenames, bool escaperequired, bool sele
FilterString.Append(" And ");
FilterString.Append("BufferSize=");
FilterString.Append(BufferSize);
FilterString.Append(" And ");
FilterString.Append("TimeOut=");
FilterString.Append(TimeOut);
FilterString.Append(")");
return FilterString.ToString();
}
Expand Down Expand Up @@ -612,6 +623,7 @@ private void ProcessWSManProtocolForTestConnection()

using (CimSession cimSession = RemoteDiscoveryHelper.CreateCimSession(sourceComp, this.Credential, WsmanAuthentication, cancel.Token, this))
{
WriteVerbose(String.Format("WMI query {0} sent to {1}", querystring, sourceComp));
for (int echoRequestCount = 0; echoRequestCount < Count; echoRequestCount++)
{
IEnumerable<CimInstance> mCollection = cimSession.QueryInstances(
Expand Down