Skip to content

PMC parse state correctly from update command's response #24850

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TravisEz13 merged 2 commits into from
Jan 23, 2025
Merged

PMC parse state correctly from update command's response #24850

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
84d82e4
Parse Json before accessing state property for PMC
anamnavi Jan 23, 2025
8ef3e7b
fix typo
anamnavi Jan 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 13 additions & 4 deletions .pipelines/EV2Specs/ServiceGroupRoot/Shell/Run/Run.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,8 +226,9 @@ function Publish-PackageToPMC() {
continue
}

$state = $rawUpdateResponse.state
if ($state -ne 'Completed') {
$state = ($rawUpdateResponse | ConvertFrom-Json).state
Write-Verbose -Verbose "update response state: $state"
if ($state -ne 'completed') {
$errorMessage.Add("Publishing package $($finalPackage.PackageName) to $pkgRepo failed: $rawUpdateResponse")
continue
}
Expand All @@ -242,11 +243,19 @@ function Publish-PackageToPMC() {

# At this point, the changes are staged and will eventually be publish.
# Running publish, causes them to go live "immediately"
$rawPublishResponse = $null
try {
pmc --config $ConfigPath repo publish $pkgRepo
$rawPublishResponse = pmc --config $ConfigPath repo publish $pkgRepo
}
catch {
$errorMessage.Add("Running final publish for package $($finalPackage.PackageName) to $pkgRepo failed. See errors above for details.")
$errorMessage.Add("Invoking final publish for package $($finalPackage.PackageName) to $pkgRepo failed. See errors above for details.")
continue
}

$publishState = ($rawPublishResponse | ConvertFrom-Json).state
Write-Verbose -Verbose "publish response state: $publishState"
if ($publishState -ne 'completed') {
$errorMessage.Add("Final publishing of package $($finalPackage.PackageName) to $pkgRepo failed: $rawPublishResponse")
continue
}
} else {
Expand Down
Loading