Skip to content

Seal internal type ClientRemoteSessionDSHandlerImpl #24705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iSazonov merged 2 commits into from
Dec 25, 2024
Merged

Seal internal type ClientRemoteSessionDSHandlerImpl #24705

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2aee656
Seal internal type `ClientRemoteSessionDSHandlerImpl`
xtqqczze Dec 24, 2024
320abd4
Fix `CS0628: new protected member declared in sealed type`
xtqqczze Dec 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 4 additions & 16 deletions src/System.Management.Automation/engine/remoting/client/remotingprotocolimplementation.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ namespace System.Management.Automation.Remoting
/// <summary>
/// Implements ServerRemoteSessionDataStructureHandler.
/// </summary>
internal class ClientRemoteSessionDSHandlerImpl : ClientRemoteSessionDataStructureHandler, IDisposable
internal sealed class ClientRemoteSessionDSHandlerImpl : ClientRemoteSessionDataStructureHandler, IDisposable
{
[TraceSourceAttribute("CRSDSHdlerImpl", "ClientRemoteSessionDSHandlerImpl")]
private static readonly PSTraceSource s_trace = PSTraceSource.GetTracer("CRSDSHdlerImpl", "ClientRemoteSessionDSHandlerImpl");
Expand Down Expand Up @@ -736,26 +736,14 @@ internal void ProcessNonSessionMessages(RemoteDataObject<PSObject> rcvdData)
#region IDisposable

/// <summary>
/// Public method for dispose.
/// Release all resources.
/// </summary>
public void Dispose()
{
Dispose(true);
_transportManager.Dispose();

GC.SuppressFinalize(this);
}

/// <summary>
/// Release all resources.
/// </summary>
/// <param name="disposing">If true, release all managed resources.</param>
protected void Dispose(bool disposing)
{
if (disposing)
{
_transportManager.Dispose();
}
}
}

#endregion IDisposable

Expand Down
Loading