Skip to content

Set LangVersion compiler option to 13.0 in Test.Common.props #24621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Ilya (iSazonov) merged 1 commit into from
Feb 8, 2025
Merged

Set LangVersion compiler option to 13.0 in Test.Common.props #24621

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion test/Test.Common.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
<Copyright>(c) Microsoft Corporation.</Copyright>

<TargetFramework>net9.0</TargetFramework>
<LangVersion>11.0</LangVersion>
<LangVersion>13.0</LangVersion>

<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
<AllowUnsafeBlocks>true</AllowUnsafeBlocks>
Expand Down
4 changes: 2 additions & 2 deletions test/tools/WebListener/Controllers/GetController.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,13 +17,13 @@ public JsonResult Index()
Hashtable args = new Hashtable();
foreach (var key in Request.Query.Keys)
{
args.Add(key, string.Join(Constants.HeaderSeparator, Request.Query[key]));
args.Add(key, string.Join(Constants.HeaderSeparator, (string)Request.Query[key]));

@iSazonov Ilya (iSazonov) Nov 27, 2024

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be fixed in Runtime repository. Is there an issue for the pattern?

@xtqqczze xtqqczze Nov 27, 2024

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please report to Runtime repo the issue?

I see there are:
dotnet/runtime#101261
dotnet/runtime#101499
dotnet/runtime#101457

xtqqczze I suggest to revert to 11.0 lang for the test project so that we can merge and don't wait comments from dotnet team.

Originally posted by Ilya (@iSazonov) in #24617 (comment)

@xtqqczze xtqqczze Nov 27, 2024

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dotnet/runtime#101499 is labelled needs-breaking-change-doc-created

@xtqqczze xtqqczze Nov 27, 2024

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Started discussion: dotnet/runtime#110216

@iSazonov Ilya (iSazonov) Dec 10, 2024 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please explicitly report (with repro steps) about the issue with cast needed? I guess it is not doc issue, it should be fixed in Runtime.

@xtqqczze xtqqczze Dec 28, 2024

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like the issue is with Microsoft.Extensions.Primitives.StringValues

@xtqqczze xtqqczze Dec 28, 2024

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The issue is a breaking change, resolution is by updating code, e.g. dotnet/aspnetcore@7e353a3

@xtqqczze xtqqczze Dec 28, 2024

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Opened issue: dotnet/docs#44102

@xtqqczze xtqqczze Dec 29, 2024

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

test/tools/WebListener/Controllers/GetController.cs(20,38): error CS0121: The call is ambiguous between the following methods or properties: 'string.Join(string?, params string?[])' and 'string.Join(string?, params ReadOnlySpan<string?>)' [test/tools/WebListener/WebListener.csproj]
test/tools/WebListener/Controllers/GetController.cs(26,41): error CS0121: The call is ambiguous between the following methods or properties: 'string.Join(string?, params string?[])' and 'string.Join(string?, params ReadOnlySpan<string?>)' [test/tools/WebListener/WebListener.csproj]

@xtqqczze xtqqczze Feb 7, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The issue is a breaking change, resolution is by updating code, e.g. dotnet/aspnetcore@7e353a3

Ilya (@iSazonov) This is a confirmed breaking change in .NET 9, see dotnet/docs#44102 (comment).

}

Hashtable headers = new Hashtable();
foreach (var key in Request.Headers.Keys)
{
headers.Add(key, string.Join(Constants.HeaderSeparator, Request.Headers[key]));
headers.Add(key, string.Join(Constants.HeaderSeparator, (string)Request.Headers[key]));
}

Hashtable output = new Hashtable
Expand Down
2 changes: 1 addition & 1 deletion test/tools/WebListener/Controllers/MultipartController.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ public JsonResult Index(IFormCollection collection)
Hashtable headers = new Hashtable();
foreach (var key in Request.Headers.Keys)
{
headers.Add(key, string.Join(Constants.HeaderSeparator, Request.Headers[key]));
headers.Add(key, string.Join(Constants.HeaderSeparator, (string)Request.Headers[key]));
}

Hashtable output = new Hashtable
Expand Down
2 changes: 1 addition & 1 deletion test/tools/WebListener/Controllers/ResponseHeadersController.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ public string Index()
Hashtable headers = new Hashtable();
foreach (var key in Request.Query.Keys)
{
headers.Add(key, string.Join(Constants.HeaderSeparator, Request.Query[key]));
headers.Add(key, string.Join(Constants.HeaderSeparator, (string)Request.Query[key]));

if (string.Equals("Content-Type", key, StringComparison.InvariantCultureIgnoreCase))
{
Expand Down