Skip to content

Set LangVersion compiler option to 13.0 in Test.Common.props - #24621

Merged
Ilya (iSazonov) merged 1 commit into
PowerShell:masterfrom
xtqqczze:LangVersion2
Feb 8, 2025
Merged

Set LangVersion compiler option to 13.0 in Test.Common.props#24621
Ilya (iSazonov) merged 1 commit into
PowerShell:masterfrom
xtqqczze:LangVersion2

Conversation

@xtqqczze

@xtqqczze xtqqczze commented Nov 26, 2024 •
edited by iSazonov
Loading

Copy link
Copy Markdown
Contributor

Close #24622

  • test/Test.Common.props

iSazonov
Ilya (iSazonov) reviewed Nov 27, 2024
View reviewed changes
Comment thread test/tools/WebListener/Controllers/GetController.cs Outdated

@iSazonov Ilya (iSazonov) Nov 27, 2024

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be fixed in Runtime repository. Is there an issue for the pattern?

@xtqqczze xtqqczze Nov 27, 2024

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please report to Runtime repo the issue?

I see there are:
dotnet/runtime#101261
dotnet/runtime#101499
dotnet/runtime#101457

xtqqczze I suggest to revert to 11.0 lang for the test project so that we can merge and don't wait comments from dotnet team.

Originally posted by Ilya (@iSazonov) in #24617 (comment)

@xtqqczze xtqqczze Nov 27, 2024

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dotnet/runtime#101499 is labelled needs-breaking-change-doc-created

@xtqqczze xtqqczze Nov 27, 2024

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Started discussion: dotnet/runtime#110216

@iSazonov Ilya (iSazonov) Dec 10, 2024 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please explicitly report (with repro steps) about the issue with cast needed? I guess it is not doc issue, it should be fixed in Runtime.

@xtqqczze xtqqczze Dec 28, 2024

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like the issue is with Microsoft.Extensions.Primitives.StringValues

@xtqqczze xtqqczze Dec 28, 2024

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The issue is a breaking change, resolution is by updating code, e.g. dotnet/aspnetcore@7e353a3

@xtqqczze xtqqczze Dec 28, 2024

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Opened issue: dotnet/docs#44102

@xtqqczze xtqqczze Dec 29, 2024

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

test/tools/WebListener/Controllers/GetController.cs(20,38): error CS0121: The call is ambiguous between the following methods or properties: 'string.Join(string?, params string?[])' and 'string.Join(string?, params ReadOnlySpan<string?>)' [test/tools/WebListener/WebListener.csproj]
test/tools/WebListener/Controllers/GetController.cs(26,41): error CS0121: The call is ambiguous between the following methods or properties: 'string.Join(string?, params string?[])' and 'string.Join(string?, params ReadOnlySpan<string?>)' [test/tools/WebListener/WebListener.csproj]

@xtqqczze xtqqczze Feb 7, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The issue is a breaking change, resolution is by updating code, e.g. dotnet/aspnetcore@7e353a3

Ilya (@iSazonov) This is a confirmed breaking change in .NET 9, see dotnet/docs#44102 (comment).

@xtqqczze
xtqqczze marked this pull request as draft November 27, 2024 09:18
@microsoft-github-policy-service microsoft-github-policy-service Bot added the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Dec 1, 2024
@xtqqczze
xtqqczze marked this pull request as ready for review December 3, 2024 23:14
@microsoft-github-policy-service microsoft-github-policy-service Bot removed the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Dec 10, 2024
@microsoft-github-policy-service microsoft-github-policy-service Bot added the Review - Needed The PR is being reviewed label Dec 17, 2024
@xtqqczze

xtqqczze commented Feb 7, 2025

Copy link
Copy Markdown
Contributor Author

Ilya (@iSazonov) can you please review?

@iSazonov Ilya (iSazonov) added the CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log label Feb 8, 2025
@iSazonov

Ilya (iSazonov) commented Feb 8, 2025

Copy link
Copy Markdown
Collaborator

/azp run

@microsoft-github-policy-service microsoft-github-policy-service Bot removed the Review - Needed The PR is being reviewed label Feb 8, 2025
@azure-pipelines

azure-pipelines Bot commented Feb 8, 2025

Copy link
Copy Markdown
Azure Pipelines successfully started running 2 pipeline(s).

@iSazonov Ilya (iSazonov) self-assigned this Feb 8, 2025
@iSazonov Ilya (iSazonov) changed the title Set LangVersion compiler option to 13.0 Set LangVersion compiler option to 13.0 in Test.Common.props Feb 8, 2025
@iSazonov
Ilya (iSazonov) enabled auto-merge (squash) February 8, 2025 06:59
@iSazonov
Ilya (iSazonov) merged commit f22ad2e into PowerShell:master Feb 8, 2025
@microsoft-github-policy-service

microsoft-github-policy-service Bot commented Feb 8, 2025 •
edited by unfurl-links Bot
Loading

Copy link
Copy Markdown
Contributor

📣 Hey xtqqczze, how did we do? We would love to hear your feedback with the link below! 🗣️

🔗 https://aka.ms/PSRepoFeedback

@xtqqczze
xtqqczze deleted the LangVersion2 branch February 8, 2025 10:18
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
@xtqqczze
Set LangVersion compiler option to 13.0 in Test.Common.props (Pow…
2186427 
…erShell#24621)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iSazonov Ilya (iSazonov) iSazonov approved these changes
@daxian-dbw Dongbo Wang (daxian-dbw) Awaiting requested review from daxian-dbw
@TravisEz13 Travis Plunk (TravisEz13) Awaiting requested review from TravisEz13
@adityapatwardhan Aditya Patwardhan (adityapatwardhan) Awaiting requested review from adityapatwardhan
@anmenaga Andrew (anmenaga) Awaiting requested review from anmenaga

Assignees

@iSazonov Ilya (iSazonov)

Labels

CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Set LangVersion compiler option to 13.0

2 participants

@xtqqczze @iSazonov