Use absolute path in FileSystemProvider.CreateDirectory#24615
Merged
iSazonov merged 4 commits intoPowerShell:masterfrom May 13, 2025
Merged
Use absolute path in FileSystemProvider.CreateDirectory#24615iSazonov merged 4 commits intoPowerShell:masterfrom
FileSystemProvider.CreateDirectory#24615iSazonov merged 4 commits intoPowerShell:masterfrom
Conversation
iSazonov
reviewed
Nov 23, 2024
test/powershell/Modules/Microsoft.PowerShell.Management/FileSystem.Tests.ps1
Outdated
Show resolved
Hide resolved
microsoft-github-policy-service
bot
added
the
Review - Needed
iSazonov
added
the
CL-General
microsoft-github-policy-service
bot
removed
the
Review - Needed
iSazonov
previously approved these changes
Feb 7, 2025
Collaborator
iSazonov
left a comment
iSazonov
left a comment
There was a problem hiding this comment.
LGTM.
The .Net method Directory.CreateDirectory(path) works right only if path is absolute path, otherwise the path is considered as relative one based on system CWD.
If we call GetParentPath(path, null) the method uses a root path for current psdrive, i.e. we calculate relative path but we need absolute path.
So the call looks like a bug for all (5) code paths where the void CreateDirectory() method is used.
test/powershell/Modules/Microsoft.PowerShell.Management/FileSystem.Tests.ps1
Outdated
Show resolved
Hide resolved
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
microsoft-github-policy-service
bot
added
the
Review - Needed
iSazonov
approved these changes
Apr 23, 2025
Collaborator
|
@Tadas Please press "Update with rebase" to get latest commits from master branch. |
microsoft-github-policy-service
bot
removed
the
Review - Needed
Tadas
force-pushed
the
new-item-force-drive-root-fix
branch
from
63348d3 to
8694def
Compare
Contributor
Author
Done |
iSazonov
reviewed
May 12, 2025
test/powershell/Modules/Microsoft.PowerShell.Management/FileSystem.Tests.ps1
Outdated
Show resolved
Hide resolved
…stem.Tests.ps1 Co-authored-by: Ilya <darpa@yandex.ru>
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
iSazonov
approved these changes
May 13, 2025
iSazonov
changed the title
FileSystemProvider.CreateDirectoryFileSystemProvider.CreateDirectory
Contributor
|
📣 Hey @@Tadas, how did we do? We would love to hear your feedback with the link below! 🗣️ 🔗 https://aka.ms/PSRepoFeedback |
Collaborator
|
@Tadas Thanks for your contribution! |
Contributor
Author
|
Thank you for your help 👍 |
SIRMARGIN
pushed a commit
to SIRMARGIN/PowerShell
that referenced
this pull request
Dec 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Remove unnecessary path split in
FileSystemProvider.CreateDirectorybecause those parts are not used anywhere and ultimately end up being combined again for theDirectory.CreateDirectorycall.PR Context
Fixes pester/Pester#2258 :
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.- [ ] Issue filed:
(which runs in a different PS Host).