Fix up buffer management getting network roots #24600
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
jborean93
force-pushed
the
wnet-buffer
branch
2 times, most recently
from
1d897a3 to
5d9951c
Compare
Fixes the logic used when getting the PSDrive DisplayRoot for network PSDrive paths to exclude null terminators.
jborean93
force-pushed
the
wnet-buffer
branch
from
5d9951c to
237a871
Compare
iSazonov
reviewed
Nov 18, 2024
src/System.Management.Automation/engine/Interop/Windows/WNetGetConnection.cs
Outdated
Show resolved
Hide resolved
iSazonov
approved these changes
Nov 18, 2024
Collaborator
iSazonov
left a comment
iSazonov
left a comment
There was a problem hiding this comment.
LGTM with one minor comment.
test/powershell/Modules/Microsoft.PowerShell.Management/Get-PSDrive.Tests.ps1
Outdated
Show resolved
Hide resolved
…Drive.Tests.ps1 Co-authored-by: Ilya <darpa@yandex.ru>
iSazonov
added
the
CL-General
microsoft-github-policy-service
bot
added
the
Review - Needed
iSazonov
requested changes
Nov 26, 2024
Collaborator
iSazonov
left a comment
iSazonov
left a comment
There was a problem hiding this comment.
@jborean93 Please address two comments - we are near to merge.
src/System.Management.Automation/engine/Interop/Windows/WNetGetConnection.cs
Outdated
Show resolved
Hide resolved
src/System.Management.Automation/engine/Interop/Windows/WNetGetConnection.cs
Outdated
Show resolved
Hide resolved
microsoft-github-policy-service
bot
added
Waiting on Author
Co-authored-by: Ilya <darpa@yandex.ru>
iSazonov
approved these changes
Nov 26, 2024
iSazonov
removed
the
Waiting on Author
Collaborator
Author
|
Thanks for the review and merge @iSazonov. Any chance to mark this as a backport candidate? |
Member
|
@PowerShell/powershell-maintainers We need more time in the preview release stage before considering this change for back-port. |
pwshBot
pushed a commit
to pwshBot/PowerShell
that referenced
this pull request
Apr 10, 2025
Fixes the logic used when getting the PSDrive DisplayRoot for network PSDrive paths to exclude null terminators.
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Fixes the logic used when getting the PSDrive DisplayRoot for network PSDrive paths to exclude null terminators.
PR Context
2nd attempt at fixes: #21064. Original was #21068.
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.- [ ] Issue filed:
(which runs in a different PS Host).