PowerShell · cmkb3 · Nov 12, 2024 · Nov 12, 2024 · Nov 13, 2024 · Nov 15, 2024
diff --git a/.gitignore b/.gitignore
@@ -111,3 +111,6 @@ msbuild.binlog
 
 # Ignore gzip files in the manpage folder
 assets/manpage/*.gz
+test/tools/Modules/nuget.config
+src/Modules/nuget.config
+nuget.config
diff --git a/src/System.Management.Automation/engine/SpecialVariables.cs b/src/System.Management.Automation/engine/SpecialVariables.cs
@@ -341,6 +341,7 @@ internal static class SpecialVariables
             SpecialVariables.WarningPreference,
             SpecialVariables.InformationPreference,
             SpecialVariables.ConfirmPreference,
+            SpecialVariables.ProgressPreference,
         };
 
         internal static readonly Type[] PreferenceVariableTypes =
@@ -352,6 +353,7 @@ internal static class SpecialVariables
             /* WarningPreference */                       typeof(ActionPreference),
             /* InformationPreference */                   typeof(ActionPreference),
             /* ConfirmPreference */                       typeof(ConfirmImpact),
+            /* ProgressPreference */                      typeof(ActionPreference),
         };
 
         // The following variables are created in every session w/ AllScope.  We avoid creating local slots when we

@@ -720,6 +720,14 @@ orderby details.LocalTupleIndex
                         (scriptCmdlet ? SpecialVariables.PreferenceVariables.Length : 0),
                 "analysis is incorrectly allocating number of locals when optimizations are disabled.");
 
+            Diagnostics.Assert(SpecialVariables.AutomaticVariables.Length == (int)AutomaticVariable.NumberOfAutomaticVariables
+                && SpecialVariables.AutomaticVariableTypes.Length == (int)AutomaticVariable.NumberOfAutomaticVariables,
+                "automatic variable enum length does not match both automatic variable and automatic variable types length.");
+
+            Diagnostics.Assert(Enum.GetNames(typeof(PreferenceVariable)).Length == SpecialVariables.PreferenceVariables.Length
+                && Enum.GetNames(typeof(PreferenceVariable)).Length == SpecialVariables.PreferenceVariableTypes.Length,
+                "preference variable enum length does not match both preference variable and preference variable types length.");
+
             var nameToIndexMap = new Dictionary<string, int>(0, StringComparer.OrdinalIgnoreCase);
             for (int i = 0; i < orderedLocals.Length; ++i)
             {

diff --git a/test/powershell/Language/Scripting/CommonParameters.Tests.ps1 b/test/powershell/Language/Scripting/CommonParameters.Tests.ps1
@@ -147,6 +147,44 @@ Describe "Common parameters support for script cmdlets" -Tags "CI" {
         }
     }
 
+    Context "ProgressAction" {
+        It "Ignores progress actions on advanced script function with no variables" {
+            $ps = [Powershell]::Create()
+            $ps.AddScript(@'
+                function test-function {
+                    [CmdletBinding()]param()
+
+                    Write-Progress "progress foo"
+                }
+                test-function -ProgressAction Ignore
+'@).Invoke()
+
+            $ps.Streams.Progress.Count | Should -Be 0
+            $ps.Streams.Error | ForEach-Object {
+                Write-Error -ErrorRecord $_ -ErrorAction Stop
+            }
+        }
+
+        It "Ignores progress actions on advanced script function with variables" {
+            $ps = [Powershell]::Create()
+            $ps.AddScript(@'
+                function test-function {
+                    [CmdletBinding()]param()
+
+                    switch($false) { default {} }
+
+                    Write-Progress "progress foo"
+                }
+                test-function -ProgressAction Ignore
+'@).Invoke()
+
+            $ps.Streams.Progress.Count | Should -Be 0
+            $ps.Streams.Error | ForEach-Object {
+                Write-Error -ErrorRecord $_ -ErrorAction Stop
+            }
+        }
+    }
+
     Context "SupportShouldprocess" {
         $script = '
                 function get-foo