Skip to content

Support PSObject wrapped values in ArgumentToEncodingTransformationAttribute #24555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iSazonov merged 2 commits into from
Nov 12, 2024
Merged

Support PSObject wrapped values in ArgumentToEncodingTransformationAttribute #24555

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
34d9cfd
Support PSObject wrapped values for -Encoding
jborean93 Nov 7, 2024
5a0f4d0
Update src/System.Management.Automation/utils/EncodingUtils.cs
jborean93 Nov 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/System.Management.Automation/utils/EncodingUtils.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,6 +115,8 @@ internal sealed class ArgumentToEncodingTransformationAttribute : ArgumentTransf
{
public override object Transform(EngineIntrinsics engineIntrinsics, object inputData)
{
inputData = PSObject.Base(inputData);

switch (inputData)
{
case string stringName:
Expand Down
2 changes: 2 additions & 0 deletions test/powershell/engine/Basic/Encoding.Tests.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,8 @@ Describe "File encoding tests" -Tag CI {
It "Parameter 'Encoding' should accept '<encoding>'" -TestCases @(
@{ encoding = 1251 }
@{ encoding = "windows-1251" }
# Piping the string creates a PSObject boxed value that we are testing.
@{ encoding = ("windows-1251" | Write-Output) }
) {
param ( $encoding )
$testFile = "${TESTDRIVE}/fileEncoding-$($encoding).txt"
Expand Down
Loading