Skip to content

Fix stderr output of console host to respect NO_COLOR #24391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SeeminglyScience merged 3 commits into from
Aug 26, 2025
Merged

Fix stderr output of console host to respect NO_COLOR #24391

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d55c29c
Fix stderr output of console host to respect NO_COLOR
SteveL-MSFT Oct 7, 2024
0308765
Merge branch 'master' into stderr-no-color
SteveL-MSFT Oct 21, 2024
62e34c4
Merge branch 'master' into stderr-no-color
SeeminglyScience Aug 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/Microsoft.PowerShell.ConsoleHost/host/msh/ConsoleHostUserInterface.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1396,6 +1396,7 @@ public override void WriteErrorLine(string value)
}
else
{
value = GetOutputString(value, SupportsVirtualTerminal);
Console.Error.WriteLine(value);
}
}
Expand Down
15 changes: 15 additions & 0 deletions test/powershell/Host/ConsoleHost.Tests.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1203,4 +1203,19 @@ Describe 'TERM env var' -Tag CI {
$env:NO_COLOR = $null
}
}

It 'No_COLOR should be respected for redirected output' {
$psi = [System.Diagnostics.ProcessStartInfo] @{
FileName = 'pwsh'
# Pass a command that succeeds and normally produces colored output, and one that produces error output.
Arguments = '-NoProfile -Command Get-Item .; Get-Content \nosuch123'
# Redirect (capture) both stdout and stderr.
RedirectStandardOutput = $true
RedirectStandardError = $true
}
$psi.Environment.Add('NO_COLOR', 1)
($ps = [System.Diagnostics.Process]::Start($psi)).WaitForExit()
$ps.StandardOutput.ReadToEnd() | Should -Not -Contain '\e'
$ps.StandardError.ReadToEnd() | Should -Not -Contain '\e'
}
Comment on lines +1207 to +1220
Copy link
Collaborator

@iSazonov iSazonov Jul 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test is passed for me in pwsh before the change... Nevertheless the change works for me in console if I manually set the env variable in cmd.exe and then run pwsh.

Copy link

@cf-rdegregory cf-rdegregory Aug 6, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I specifically noticed the original issue when running PowerShell inside a Docker container (for example, using mcr.microsoft.com/powershell:7.5-alpine-3.17). I'd imagine the env var injection into the pwsh process in that scenario is similar to running pwsh from cmd.exe, and why the issue is reproducible by setting the env var outside of pwsh first.

}
Loading