Improve cim ETS member inference completion#24235
Merged
SeeminglyScience merged 3 commits intoDec 12, 2024
Merged
Conversation
jborean93
reviewed
Sep 5, 2024
SeeminglyScience
approved these changes
Dec 12, 2024
SeeminglyScience
left a comment
Contributor
There was a problem hiding this comment.
LGTM, thanks Martin!
Contributor
|
📣 Hey @MartinGC94, how did we do? We would love to hear your feedback with the link below! 🗣️ 🔗 https://aka.ms/PSRepoFeedback |
21 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Improves the member type inference for cim based commands by adding a fallback to the short namespaceless name if a full name was specified.
PR Context
Many of the CDXML modules uses the
.types.ps1xmltype files to add additional members. In most cases they use a short name that doesn't specify the WMI namespace like:Microsoft.Management.Infrastructure.CimInstance#MSFT_NetFirewallRulebut they still declare the full type with the namespace in the outputtype attribute:Microsoft.Management.Infrastructure.CimInstance#root/standardcimv2/MSFT_NetFirewallRuleThis is completely valid as the ciminstance type adapter adds both the full and short name to the list of typenames: https://github.com/PowerShell/PowerShell/blob/master/src/System.Management.Automation/cimSupport/other/ciminstancetypeadapter.cs#L234
So the type inference code also needs to handle this.
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.- [ ] Issue filed:
(which runs in a different PS Host).