Fix progress calculation on Remove-Item #23869
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
As for new test, we could create new test hook - if the hook is on we save Task.Run() in the test hook and wait the task later in remove item code. This makes the code sync |
Collaborator
Author
|
I have reservations about tests that alter behavior during execution. This approach can lead to discrepancies, as seen in this issue, where the behavior observed during testing differs from that in the released package. Additionally, it increases the complexity of the code. I will defer to the Working Group on this matter and leave the decision, and work if they want it, to them. |
SteveL-MSFT
approved these changes
Jun 3, 2024
microsoft-github-policy-service
bot
added
the
Review - Needed
daxian-dbw
added
CL-General
Fix the percentage completion calculation for Remove-Item when deleting a directory or file that have no size. As the size calculation is done in a background thread this may or may not happen due to a race condition of when it is calculated.
daxian-dbw
force-pushed
the
remove-progress
branch
from
9132b75 to
d25cbd1
Compare
Contributor
|
📣 Hey @jborean93, how did we do? We would love to hear your feedback with the link below! 🗣️ 🔗 https://aka.ms/PSRepoFeedback |
chrisdent-de
pushed a commit
to chrisdent-de/PowerShell
that referenced
this pull request
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Fix the percentage completion calculation for Remove-Item when deleting a directory or file that have no size. As the size calculation is done in a background thread this may or may not happen due to a race condition of when it is calculated.
PR Context
Fixes: #23868
I can't write a test for this as the
_totalFilesand_totalBytescalculation is done in a background thread and will most likely run after the progress check is done in the main thread. The changes are consistent in what is done in #19038 for a similar problem.PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.- [ ] Issue filed:
(which runs in a different PS Host).