Spelling locals #2154
Spelling locals #2154
Conversation
|
Hi @jsoref, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution! The agreement was validated by Microsoft and real humans are currently evaluating your PR. TTYL, MSBOT; |
|
There are compilation errors introduced by your changes (click red crosses to go to the detailed logs). Please fix them first, before we evaluate the PR |
jsoref
force-pushed
the
spelling-locals
branch
2 times, most recently
from
0059f4b to
f33b2d2
Compare
|
I was worried The second failure is apparently a selection miss (I'm basically manually recording a subset of changes into commits -- and apparently I missed one). |
There was a problem hiding this comment.
Can we separate script files (.psm1, .ps1) into a separate PR?
C# code has static compile checks, but psm1 files would need more attention.
There was a problem hiding this comment.
hitten is correct here. It means, this code path should not be hit (executed).
There was a problem hiding this comment.
Normally that would be spelled hit. Or one could use run or executed for clarity.
There was a problem hiding this comment.
... or called.
@vors if you suggest a replacement (called, executed, hit, run, or used), I can fix it up (or I can split it off into its own PR if that helps this one merge faster).
There was a problem hiding this comment.
Yes, the separate PR is always better :)
jsoref
force-pushed
the
spelling-locals
branch
from
78cda16 to
7c6833e
Compare
jsoref
force-pushed
the
spelling-locals
branch
from
7c6833e to
c8e3013
Compare
There was a problem hiding this comment.
oh, these C# strings that represents powershell are the worst for editing :)
This $setMaxIdleTimeoutFirst change looks good.
jsoref
force-pushed
the
spelling-locals
branch
from
c8e3013 to
bf7f0c2
Compare
There was a problem hiding this comment.
PSReadLine is another module that has its own repo https://github.com/lzybkr/PSReadLine and will be replaced by git submodule or something similar
|
Overall looks good! Before we can merge, please
BTW, extra thank you for keeping the history clean! |
jsoref
force-pushed
the
spelling-locals
branch
from
bf7f0c2 to
fbec6ec
Compare
|
@vors: done |
|
Thank you @jsoref ! |
5 participants
These changes are mostly to arguments, local variables, local functions, and non-public methods (mostly private, some protected), and a couple of comments (which I apparently failed to group w/ a previous comments only PR).
I'm trying to exclude public methods from this series (that's reserved for another PR later) -- If there are public methods in here, I'll gladly drop them.
As there are quite a few changes, I've tried to group changes into commits per directory tree.