Skip to content

add file description to pwsh.exe #21352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iSazonov merged 2 commits into from
Mar 26, 2024
Merged

add file description to pwsh.exe #21352

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6d91607
add file description to `pwsh.exe`
Mar 18, 2024
ac4139a
move file description to common
Mar 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions PowerShell.Common.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,6 +137,7 @@
<Product>PowerShell</Product>
<Company>Microsoft Corporation</Company>
<Copyright>(c) Microsoft Corporation.</Copyright>
<AssemblyTitle>PowerShell 7</AssemblyTitle>
Copy link
Collaborator

@kilasuit kilasuit Mar 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a need to have this have 7 in there as the description for 5.1 is Windows PowerShell, unless you see a need for in future to distinguish between a PowerShell 7 & a PowerShell 8 instance

Copy link
Member Author

@SteveL-MSFT SteveL-MSFT Mar 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The branding of PS7 is PowerShell 7. The current plan is to not have a situation where we'd have a PowerShell 8. If there becomes a need for a PowerShell 8, it would mean significant breaking changes and we'd brand it PowerShell 8 vs PowerShell that is version 8.x.


<TargetFramework>net9.0</TargetFramework>
<LangVersion>11.0</LangVersion>
Expand Down