Skip to content

Fix a null reference exception when 'Runspace.DefaultRunspace' is null #21344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
daxian-dbw merged 1 commit into from
Mar 14, 2024
Merged

Fix a null reference exception when 'Runspace.DefaultRunspace' is null #21344

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions src/System.Management.Automation/security/wldpNativeMethods.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@

using System.Diagnostics.CodeAnalysis;
using System.Management.Automation.Internal;
using System.Management.Automation.Runspaces;
using System.Management.Automation.Tracing;
using System.Runtime.InteropServices;

Expand Down Expand Up @@ -91,9 +92,8 @@ internal static void LogWDACAuditMessage(
string messageToWrite = message;

// Augment the log message with current script information from the script debugger, if available.
context ??= System.Management.Automation.Runspaces.LocalPipeline.GetExecutionContextFromTLS();
context ??= LocalPipeline.GetExecutionContextFromTLS();
bool debuggerAvailable = context is not null &&
context._debugger is not null &&
context._debugger is ScriptDebugger;

if (debuggerAvailable)
Expand All @@ -108,10 +108,9 @@ context._debugger is not null &&
PSEtwLog.LogWDACAuditEvent(title, messageToWrite, fqid);

// We drop into the debugger only if requested and we are running in the interactive host session runspace (Id == 1).
if (debuggerAvailable &&
dropIntoDebugger is true &&
if (debuggerAvailable && dropIntoDebugger &&
context._debugger.DebugMode.HasFlag(DebugModes.LocalScript) &&
System.Management.Automation.Runspaces.Runspace.DefaultRunspace.Id == 1 &&
Runspace.DefaultRunspace?.Id == 1 &&
context.DebugPreferenceVariable.HasFlag(ActionPreference.Break) &&
context.InternalHost?.UI is not null)
{
Expand Down