Fix Write-Host to respect OutputRendering = PlainText#21188
Merged
daxian-dbw merged 1 commit intoPowerShell:masterfrom Aug 4, 2025
Merged
Fix Write-Host to respect OutputRendering = PlainText#21188daxian-dbw merged 1 commit intoPowerShell:masterfrom
Write-Host to respect OutputRendering = PlainText#21188daxian-dbw merged 1 commit intoPowerShell:masterfrom
Conversation
|
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
daxian-dbw
approved these changes
Aug 4, 2025
Member
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
|
📣 Hey @@SteveL-MSFT, how did we do? We would love to hear your feedback with the link below! 🗣️ 🔗 https://aka.ms/PSRepoFeedback |
Amro1984
pushed a commit
to Amro1984/PowerShell
that referenced
this pull request
Aug 12, 2025
Amro1984
pushed a commit
to Amro1984/PowerShell
that referenced
this pull request
Aug 12, 2025
SIRMARGIN
pushed a commit
to SIRMARGIN/PowerShell
that referenced
this pull request
Dec 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Write-Hostavoids some of the existing checks forPSStyle.OutputRendering. So the change is in the internal host interface to not use the overloads for color whenOutputRenderingis explicitlyplaintext. Tested manually as redirection ofpwshgoes a different path and works as expected and the bug only shows up when writing directly to the console.PR Context
Fix #21168
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.(which runs in a different PS Host).