Skip to content

Conversation

@daxian-dbw
Copy link
Member

Backport #20689

daxian-dbw and others added 30 commits October 21, 2021 17:45
Update change log for v7.2.0-rc.1 release
…s for `R2R` images (#16297)

* Clean up crossgen related build scripts

* Fix ci.psm1

* Clean up '-CrossGen' use in a few other files
Co-authored-by: TravisEz13 <TravisEz13@users.noreply.github.com>
* Merged PR 17994: Update change log for 7.2.0

Update change log for 7.2.0

# Conflicts:
#	.spelling

* add blank change log for 7.3

Co-authored-by: Aditya Patwardhan <adityap@microsoft.com>
…foJson (#16404)

Co-authored-by: Aditya Patwardhan <adityap@microsoft.com>
Co-authored-by: Robert Holt <rjmholt@gmail.com>
…l components (#16340)

* Use notice task to generate license assuming cgmanifest contains all components

* fix capture task

* fix output location

* cgmanifest using latest public

* fix additional attributions path

* split into stages to allow retry without restarting

* manually append additional attributions

* remove dead comment

* Revert "cgmanifest using latest public"

This reverts commit 6bed867.
…rt-Job (#16535)

* Bring back pwsh.exe for framework dependent packages to support Start-Job

* Update wix file

* Add release tests for fxd packages

* Fix tests

* Fix stage dependencies

* Address CR comments

* Fix typo

* Add value for the hashtable item
TravisEz13 and others added 22 commits September 20, 2023 09:28
…ted remoting sessions

Cherry picked from !27698

Related work items: #152543
Update changelog for v7.2.15 release
Update to >NET 6 and TPN
Fix issues with merging backports in packaging
Changelog for release v7.2.16
Redact Auth header content from ErrorRecord
…bal tool to private blob and move to CDN during release

Backport #20659
Changelog for release v7.2.17
@pull-request-quantifier-deprecated

This PR has 13703 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!


Quantification details

Label      : Extra Large
Size       : +9945 -3758
Percentile : 100%

Total files changed: 242

Change summary by file extension:
.editorconfig : +2 -0
.md : +1287 -833
.psm1 : +821 -611
.yml : +2916 -625
.json : +2952 -44
.gitignore : +2 -1
.spelling : +50 -1
.props : +6 -10
.xml : +2 -0
.txt : +118 -57
.ronn : +127 -47
.wxs : +4 -24
.config : +1 -1
.yaml : +0 -0
.cs : +439 -573
.csproj : +62 -52
.psd1 : +24 -34
.resx : +9 -0
.js : +0 -37
.ps1 : +1122 -448
.lock : +0 -0
docker/tests/Templates/centos7/Dockerfile : +0 -19
docker/tests/Templates/debian.9/Dockerfile : +0 -25
docker/tests/Templates/fedora28/Dockerfile : +0 -22
docker/tests/Templates/fxdependent-centos7/Dockerfile : +0 -25
docker/tests/Templates/fxdependent-debian.9/Dockerfile : +0 -26
docker/tests/Templates/fxdependent-dotnetsdk-latest/Dockerfile : +0 -26
docker/tests/Templates/fxdependent-fedora28/Dockerfile : +0 -32
docker/tests/Templates/fxdependent-opensuse42.3/Dockerfile : +0 -35
docker/tests/Templates/fxdependent-ubuntu16.04/Dockerfile : +0 -33
docker/tests/Templates/fxdependent-ubuntu18.04/Dockerfile : +0 -26
docker/tests/Templates/opensuse42.3/Dockerfile : +0 -31
docker/tests/Templates/ubuntu16.04/Dockerfile : +0 -25
docker/tests/Templates/ubuntu18.04/Dockerfile : +0 -25
test/docker/networktest/Dockerfile : +1 -1
tools/releaseBuild/Images/microsoft_powershell_alpine3/Dockerfile : +0 -9

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detected.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.


Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

@microsoft-github-policy-service
Copy link
Contributor

microsoft-github-policy-service bot commented Jan 9, 2024

📣 Hey @daxian-dbw, how did we do? We would love to hear your feedback with the link below! 🗣️

🔗 https://aka.ms/PSRepoFeedback

@daxian-dbw daxian-dbw deleted the backport-20689 branch January 9, 2024 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.