-
Notifications
You must be signed in to change notification settings - Fork 8.1k
Added progress bar for Remove-Item cmdlet
#20778
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added progress bar for Remove-Item cmdlet
#20778
Conversation
|
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
kilasuit
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving based on my testing of the build artifact from this PR, however would still like to have someone else review the code.
|
Any update? Has an alternative been presented somewhere else? |
SteveL-MSFT
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
SeeminglyScience
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR Summary
Fixes #19538
Added progress bar for
Remove-Itemcmdlet.PR Context
Currently there is no progress bar when running
Remove-Item -Path somedir -Recurse -Force. I've included a progress bar similar toCopy-Item.Some reason when using
terminalizerthe progress bar doesn't show up right and overlaps the status activity message. If you run this on its own it displays fine. Couldn't work around this to get a better terminal recording on Windows, open to suggestions 😄.PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.(which runs in a different PS Host).