Skip to content

Fix regression -Tail 0 -Wait - #20734

Merged
Ilya (iSazonov) merged 2 commits into
PowerShell:masterfrom
CarloToso:fix-regression-tail
Jan 11, 2024
Merged

Ilya (iSazonov) merged 2 commits into
PowerShell:masterfrom
CarloToso:fix-regression-tail

Conversation

@CarloToso

@CarloToso CarloToso commented Nov 21, 2023 •

Copy link
Copy Markdown
Contributor

PR Summary

Fixes a regression introduced by #19715; when Get-Content -Wait is used with -Tail 0 wait is ignored

PR Context

fixes #20731 Michael Klement (@mklement0)

PR Checklist

@iSazonov Ilya (iSazonov) added the CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log label Nov 21, 2023

@iSazonov Ilya (iSazonov) left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be great to add tests for -Wait.

@microsoft-github-policy-service microsoft-github-policy-service Bot added the Review - Needed The PR is being reviewed label Nov 28, 2023
@NoMoreFood

Copy link
Copy Markdown
Contributor

Since this was an unintended breaking change, it would be great to see this incorporated in 7.4.1.

@SteveL-MSFT Steve Lee (SteveL-MSFT) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a test

@microsoft-github-policy-service microsoft-github-policy-service Bot added Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept and removed Review - Needed The PR is being reviewed labels Dec 20, 2023
@microsoft-github-policy-service microsoft-github-policy-service Bot removed the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Dec 21, 2023
@CarloToso

Copy link
Copy Markdown
Contributor Author

Please add a test

Done (unrelated test failure)

@microsoft-github-policy-service microsoft-github-policy-service Bot added the Review - Needed The PR is being reviewed label Dec 28, 2023
@iSazonov
Ilya (iSazonov) enabled auto-merge (squash) January 11, 2024 03:26
@iSazonov Ilya (iSazonov) self-assigned this Jan 11, 2024
@microsoft-github-policy-service microsoft-github-policy-service Bot removed the Review - Needed The PR is being reviewed label Jan 11, 2024
auto-merge was automatically disabled January 11, 2024 05:09

Pull request was closed

@pull-request-quantifier-deprecated

Copy link
Copy Markdown

This PR has 12 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!


Quantification details

Label      : Extra Small
Size       : +10 -2
Percentile : 4.8%

Total files changed: 2

Change summary by file extension:
.cs : +2 -2
.ps1 : +8 -0

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detected.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.


Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

@iSazonov
Ilya (iSazonov) merged commit 68204ae into PowerShell:master Jan 11, 2024
@NoMoreFood

Copy link
Copy Markdown
Contributor

Disappointingly, looks like this didn't make it to 7.4.1. Is there still hope for 7.4.2? Being able to tail a log file like this is very important for adhoc administrator use, and I know I've personally used it scripts that watch log files.

@iSazonov

Copy link
Copy Markdown
Collaborator

Will be in 7.4.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Backport-7.4.x-Done CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log Extra Small

Projects

None yet

Development

Successfully merging this pull request may close these issues.

PS 7.4.0: "-Tail 0" ignores "-Wait" and immediately stops Get-Content

7 participants