Fixing API set versioning to get PowerShell Core working on Windows 7 #2072
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @mirichmo, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
TTYL, MSBOT; |
Contributor
There was a problem hiding this comment.
Can we replace the string literal with the constant from PinvokeDllNames?
mirichmo
force-pushed
the
mirichmo/fixing-win7
branch
from
4685456 to
f16bc1a
Compare
Member
|
LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1705 by correcting the API set versions used to match those shipped with CoreCLR's downlevel API set package.
This makes it possible to run PS on Win 7.
I verified remoting with WMF 4.0 and ran the Nano Server test pass against it. I got an 83% pass rate, so there are additional issues to resolve for Win 7.