Skip to content

Discuss oddly spelled words (please do not merge) #2058

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jsoref wants to merge 1 commit into from
Closed

Discuss oddly spelled words (please do not merge) #2058

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/Microsoft.WSMan.Management/CredSSP.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -440,7 +440,7 @@ public class EnableWSManCredSSPCommand : WSManCredSSPCommandBase, IDisposable/*,

//private const string DelegateComputerParam = "DelegateComputer";
//private String[] delegatecomputer;
//private RuntimeDefinedParameterDictionary dyanmicParameters = new RuntimeDefinedParameterDictionary();
//private RuntimeDefinedParameterDictionary dynamicParameters = new RuntimeDefinedParameterDictionary();
Copy link
Contributor Author

@jsoref jsoref Aug 30, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand how this works... Are these // marks not actually comments? Or is this file not compiled?

Copy link
Contributor Author

@jsoref jsoref Aug 30, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mirichmo can you find someone who can comment on this? thanks.

Copy link
Collaborator

@vors vors Sep 2, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I researched the history and that's how the code was originally written in 2009 :)

I think it's safe to remove this commented-out code.


#endregion

Expand Down Expand Up @@ -544,7 +544,7 @@ object IDynamicParameters.GetDynamicParameters()
// return null if the role is not client.
if (!Role.Equals(ClientRole, StringComparison.OrdinalIgnoreCase))
{
return dyanmicParameters;
return dynamicParameters;
}

// Construct attributes for the DelegateComputer parameter
Expand All @@ -561,9 +561,9 @@ object IDynamicParameters.GetDynamicParameters()
DelegateComputerParam,
typeof(string[]),
delegateComputerAttributeCollection);
dyanmicParameters.Add(DelegateComputerParam, delegateComputer);
dynamicParameters.Add(DelegateComputerParam, delegateComputer);

return dyanmicParameters;
return dynamicParameters;

} // GetDynamicParameters*/

Expand Down Expand Up @@ -603,7 +603,7 @@ private void EnableClientSideSettings()
return;
}
// Extract delegateComputer information from dynamic parameters collection
//RuntimeDefinedParameter delegateComputerParameter = dyanmicParameters[DelegateComputerParam];
//RuntimeDefinedParameter delegateComputerParameter = dynamicParameters[DelegateComputerParam];
//delegatecomputer = (string[])delegateComputerParameter.Value;

string newxmlcontent = @"<cfg:Auth xmlns:cfg=""http://schemas.microsoft.com/wbem/wsman/1/config/client/auth""><cfg:CredSSP>true</cfg:CredSSP></cfg:Auth>";
Expand Down