Discuss oddly spelled words (please do not merge) #2058
Conversation
|
Hi @jsoref, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution! The agreement was validated by Microsoft and real humans are currently evaluating your PR. TTYL, MSBOT; |
There was a problem hiding this comment.
My assumption is that the two ls are just stray, but it's pretty odd...
There was a problem hiding this comment.
Agreed, it's New-PackageSource.
There was a problem hiding this comment.
Looks like New-PacakageSource got inserted in the middle of the word "call"
|
@jsoref It looks like you got the information that you needed. I'd like to close this PR unless you are going to update it with merge-able fixes. |
|
If you're OK with one stray PR for a little bit, I'd rather have one than repeatedly opening additional ones (the bot is annoying). If I don't put anything into it in two weeks, please feel free to close it. But it's not a huge deal if you want to close it sooner... Yes, I've taken these two answers. |
| //private const string DelegateComputerParam = "DelegateComputer"; | ||
| //private String[] delegatecomputer; | ||
| //private RuntimeDefinedParameterDictionary dyanmicParameters = new RuntimeDefinedParameterDictionary(); | ||
| //private RuntimeDefinedParameterDictionary dynamicParameters = new RuntimeDefinedParameterDictionary(); |
There was a problem hiding this comment.
I don't understand how this works... Are these // marks not actually comments? Or is this file not compiled?
There was a problem hiding this comment.
@mirichmo can you find someone who can comment on this? thanks.
There was a problem hiding this comment.
I researched the history and that's how the code was originally written in 2009 :)
I think it's safe to remove this commented-out code.
|
I can provide a commit to talk about |
|
All of the |
|
@lzybkr ok |
|
I opened #2171 for the unused code. With that, it looks like all other things have been discussed, so I'm going to close the PR. |
7 participants
This isn't meant as a real pull request. While working on https://github.com/jsoref/PowerShell/tree/spelling I came across two tokens for which I wasn't particularly certain what the intended words were.
If someone could identify the correct words, I'd be happy to include them in a pull request.