-
Notifications
You must be signed in to change notification settings - Fork 8.1k
Fix unixmode to handle setuid/sticky when not executable #20366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix unixmode to handle setuid/sticky when not executable #20366
Conversation
test/powershell/Modules/Microsoft.PowerShell.Management/UnixStat.Tests.ps1
Outdated
Show resolved
Hide resolved
ff2c2b3 to
310c4d5
Compare
|
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
…at.Tests.ps1 Co-authored-by: Ilya <darpa@yandex.ru>
Use stackalloc rather than new for character mode array.
…onstants." This reverts commit 22769e9cd46bfc3620f96081e3b3783fa4e2d485.
Use stackalloc rather than new for character mode array.
Co-authored-by: Dongbo Wang <dongbow@microsoft.com>
830080b to
00a4b6e
Compare
Co-authored-by: Dongbo Wang <dongbow@microsoft.com>
00a4b6e to
70292b0
Compare
daxian-dbw
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
📣 Hey @JamesWTruher, how did we do? We would love to hear your feedback with the link below! 🗣️ 🔗 https://forms.office.com/r/P926k48jRJ |
PR Summary
This is a fix for #20278
PR Context
I'm not addressing the CodeFactor reported complexity as I don't believe this method is overly complicated.
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.(which runs in a different PS Host).