Skip to content

Conversation

@JamesWTruher
Copy link
Collaborator

This replaces PR 1834 from the private fork I had
it adds approximately 30 new tests for cmdlets which currently have little or no tests

This replaces PR 1834 from the private fork I had
@msftclas
Copy link

Hi @JamesWTruher, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!


It looks like you're a Microsoft contributor (Jim Truher). If you're full-time, we DON'T require a Contribution License Agreement. If you are a vendor, please DO sign the electronic Contribution License Agreement. It will take 2 minutes and there's no faxing! https://cla.microsoft.com.

TTYL, MSBOT;

@@ -0,0 +1,76 @@
Describe "Job Cmdlet Tests" -Tag "CI" {
Copy link
Member

@daxian-dbw daxian-dbw Aug 22, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

job cmdlets don't work on *unix platforms, see #1972
maybe this test should be run only on windows for now.

Copy link
Collaborator Author

@JamesWTruher JamesWTruher Aug 22, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as it turns out the cmdlets actually do run on both platforms - the jobs themselves don't work, but the cmdlets do work to a certain extent. As soon as the job cmdlets actually execute the tests, these should be able to just start working. Currently, job creation fails on both platforms which is why the tests which check for proper execution of the job are marked as pending.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks Jim, that sounds reasonable. BTW, what does -pending mean in Pester tests?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pending is a way that we can track those tests which will be eventually enabled. We will start tracking Pending tests and drive that count to 0 over time. A skipped test is a test which isn't really ever applicable (for example, a test that is only applicable to Linux, Core. or windows).

@daxian-dbw
Copy link
Member

LGTM.

@daxian-dbw daxian-dbw merged commit 20a525b into PowerShell:master Aug 23, 2016
@JamesWTruher JamesWTruher deleted the jameswtruher/TestGapFill-001 branch August 23, 2016 17:36
@JamesWTruher
Copy link
Collaborator Author

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

WG-Quality-Test issues in a test or in test infrastructure

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants