-
Notifications
You must be signed in to change notification settings - Fork 8.1k
Filling test gaps (issue 2022) - this replaces PR 1834 #2023
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Filling test gaps (issue 2022) - this replaces PR 1834 #2023
Conversation
This replaces PR 1834 from the private fork I had
|
Hi @JamesWTruher, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
TTYL, MSBOT; |
| @@ -0,0 +1,76 @@ | |||
| Describe "Job Cmdlet Tests" -Tag "CI" { | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
job cmdlets don't work on *unix platforms, see #1972
maybe this test should be run only on windows for now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as it turns out the cmdlets actually do run on both platforms - the jobs themselves don't work, but the cmdlets do work to a certain extent. As soon as the job cmdlets actually execute the tests, these should be able to just start working. Currently, job creation fails on both platforms which is why the tests which check for proper execution of the job are marked as pending.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks Jim, that sounds reasonable. BTW, what does -pending mean in Pester tests?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pending is a way that we can track those tests which will be eventually enabled. We will start tracking Pending tests and drive that count to 0 over time. A skipped test is a test which isn't really ever applicable (for example, a test that is only applicable to Linux, Core. or windows).
|
LGTM. |
|
thanks! |
This replaces PR 1834 from the private fork I had
it adds approximately 30 new tests for cmdlets which currently have little or no tests