Skip to content

Start using new packages.microsoft.com cli #20141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
TravisEz13 merged 10 commits into from
Sep 5, 2023
Merged

Start using new packages.microsoft.com cli #20141

TravisEz13 merged 10 commits into from
Sep 5, 2023

Conversation

@TravisEz13
Copy link
Member

@TravisEz13 TravisEz13 commented Aug 18, 2023 •
edited
Loading

PR Summary

Start using new packages.microsoft.com cli

PR Context

PR Checklist

@TravisEz13 TravisEz13 marked this pull request as draft August 18, 2023 20:33
JamesWTruher
JamesWTruher reviewed Aug 18, 2023
View reviewed changes
tools/releaseBuild/azureDevOps/templates/release-PublishPackageMsftCom.yml Outdated
SkipPublish = $${{ parameters.skipPublish }}
}
$params | Out-String -width 9999 | write-Verbose -Verbose
& '$(Pipeline.Workspace)/tools/packages.microsoft.com/releaseLinuxPackages.ps1' -MappingFilePath '$(System.DefaultWorkingDirectory)/tools/packages.microsoft.com/mapping.json' @params
Copy link
Collaborator

@JamesWTruher JamesWTruher Aug 18, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perhaps we should change the path in the tools repo so when it's merged we don't break the servicing branches

JamesWTruher
JamesWTruher reviewed Aug 18, 2023
View reviewed changes
tools/releaseBuild/azureDevOps/templates/release-PublishPackageMsftCom.yml Outdated
SkipPublish = $${{ parameters.skipPublish }}
}
$params | Out-String -width 9999 | write-Verbose -Verbose
& '$(Pipeline.Workspace)/tools/packages.microsoft.com/releaseLinuxPackages.ps1' -MappingFilePath '$(System.DefaultWorkingDirectory)/tools/packages.microsoft.com/mapping.json' @params
Copy link
Collaborator

@JamesWTruher JamesWTruher Aug 18, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also, why isn't the mappingfilePath just part of the params

JamesWTruher
JamesWTruher reviewed Aug 18, 2023
View reviewed changes
Copy link
Collaborator

@JamesWTruher JamesWTruher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it seems fine

@microsoft-github-policy-service microsoft-github-policy-service bot added the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Aug 22, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot removed the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Aug 29, 2023
TravisEz13
TravisEz13 commented Aug 30, 2023
View reviewed changes
@TravisEz13 TravisEz13 force-pushed the pmcv2.2 branch 2 times, most recently from d3c7d19 to 5251b2d Compare August 30, 2023 22:12
@TravisEz13 TravisEz13 merged commit 4ee8864 into PowerShell:master Sep 5, 2023
@TravisEz13 TravisEz13 deleted the pmcv2.2 branch September 5, 2023 20:12
@TravisEz13 TravisEz13 added CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log BackPort-7.4.x-Approved Backport-7.3.x-Approved and removed BackPort-7.4.x-Consider Backport-7.3.x-Consider labels Sep 6, 2023
@daxian-dbw daxian-dbw mentioned this pull request Sep 11, 2023
Merged
daxian-dbw pushed a commit that referenced this pull request Sep 11, 2023
@TravisEz13 @daxian-dbw
Start using new packages.microsoft.com cli (#20141)
4d0f04f 
* Add verbose to clone

* Add skip publish parameter

* install the pmc cli

* Address PR comments

* use updated path

* switch to main-mirror

* Don't install python

* Update tools/releaseBuild/azureDevOps/templates/release-PublishPackageMsftCom.yml

* Update tools/releaseBuild/azureDevOps/releasePipeline.yml
daxian-dbw added a commit that referenced this pull request Sep 11, 2023
@daxian-dbw
[release/v7.2.14] Start using new packages.microsoft.com cli (#20141) (…
d6c0dba 
…#20241)
@daxian-dbw daxian-dbw mentioned this pull request Sep 11, 2023
Merged
daxian-dbw pushed a commit that referenced this pull request Sep 11, 2023
@TravisEz13 @daxian-dbw
Start using new packages.microsoft.com cli (#20141)
f206e00 
* Add verbose to clone

* Add skip publish parameter

* install the pmc cli

* Address PR comments

* use updated path

* switch to main-mirror

* Don't install python

* Update tools/releaseBuild/azureDevOps/templates/release-PublishPackageMsftCom.yml

* Update tools/releaseBuild/azureDevOps/releasePipeline.yml
daxian-dbw added a commit that referenced this pull request Sep 11, 2023
@daxian-dbw
[release/v7.3.7] Start using new packages.microsoft.com cli (#20141) (#…
6922d5a 
…20252)
@daxian-dbw daxian-dbw mentioned this pull request Sep 11, 2023
Merged
daxian-dbw pushed a commit that referenced this pull request Sep 11, 2023
@TravisEz13 @daxian-dbw
Start using new packages.microsoft.com cli (#20141)
eb48d8e 
* Add verbose to clone

* Add skip publish parameter

* install the pmc cli

* Address PR comments

* use updated path

* switch to main-mirror

* Don't install python

* Update tools/releaseBuild/azureDevOps/templates/release-PublishPackageMsftCom.yml

* Update tools/releaseBuild/azureDevOps/releasePipeline.yml
daxian-dbw added a commit that referenced this pull request Sep 12, 2023
@daxian-dbw
[release/v7.4.0-preview.6] Start using new packages.microsoft.com cli (…
648461a 
…#20141) (#20258)
VindSkyggen pushed a commit to VindSkyggen/PowerShell that referenced this pull request Dec 26, 2023
@daxian-dbw @VindSkyggen
[release/v7.4.0-preview.6] Start using new packages.microsoft.com cli (…
c654d23 
…PowerShell#20141) (PowerShell#20258)
@TravisEz13 TravisEz13 mentioned this pull request Apr 16, 2024
Closed
@TravisEz13 TravisEz13 mentioned this pull request Jul 9, 2024
Merged
chrisdent-de pushed a commit to chrisdent-de/PowerShell that referenced this pull request Sep 12, 2024
@daxian-dbw @chrisdent-de
[release/v7.4.0-preview.6] Start using new packages.microsoft.com cli (…
8ffe564 
…PowerShell#20141) (PowerShell#20258)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adityapatwardhan adityapatwardhan adityapatwardhan approved these changes

@daxian-dbw daxian-dbw Awaiting requested review from daxian-dbw

@anmenaga anmenaga Awaiting requested review from anmenaga

+2 more reviewers

@JamesWTruher JamesWTruher JamesWTruher left review comments

@anamnavi anamnavi anamnavi approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Backport-7.2.x-Done Backport-7.3.x-Done BackPort-7.4.x-Done CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log MustHave Small

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@TravisEz13 @JamesWTruher @adityapatwardhan @anamnavi @daxian-dbw