-
Notifications
You must be signed in to change notification settings - Fork 8.1k
fix: typo donet -> dotnet #20122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: typo donet -> dotnet #20122
Conversation
|
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
| $dotnetAzureFeed = if (-not $env:__DOTNET_RUNTIME_FEED ) { $dotnetMetadata.Sdk.azureFeed } | ||
| $dotnetAzureFeedSecret = $env:__DOTNET_RUNTIME_FEED_KEY |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are those env variables internal-only? Could this change possibly break workflow of someone who used the mistyped variables?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Based on what I've observed, they seem to be internal-only, but it might be prudent for others to conduct a review.
|
@adityapatwardhan can you please review the environment variable names? |
|
I will double check the variable names and confirm if the infrastructure pipelines have the same typo.. I can update them their too. |
|
this change should not cause any breaks in the release pipeline. |
|
This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days. |
1 similar comment
|
This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days. |
PR Summary
PR Context
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.(which runs in a different PS Host).