-
Notifications
You must be signed in to change notification settings - Fork 8.1k
Fix Out-GridView by implementing Clone() method to replace old use of binary format serialization
#20050
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…of binary format serialization
|
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
JamesWTruher
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we have validation anywhere for this?
|
@JamesWTruher no automation, so just some manual validation with filtering |
daxian-dbw
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR Summary
The PR to move to .NET 8 preview.4 removed all use of the binary format serializer since it is no longer supported in .NET. This inadvertently broke
Out-GridViewwhich heavily depends on binary serialization to make copies of FilterRules. The fix here is to introduce a newClone()method in the abstract base class and implement it for each of the derived FilterRules.PR Context
Fix #20015
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.(which runs in a different PS Host).