Repository navigation
Use OrdinalIgnoreCase to lookup script breakpoints - #20046
Conversation
|
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
Dongbo Wang (daxian-dbw)
left a comment
There was a problem hiding this comment.
LGTM. Thanks Frode Flaten (@fflaten)!
Andy Jordan (andyleejordan)
left a comment
There was a problem hiding this comment.
Excellent work Frode Flaten (@fflaten)! I confirmed this resolves the issue. Thanks so much!
PR Summary
Reverts to
OrdinalIgnoreCasestring comparison when looking up breakpoints for a specific script.PR Context
Unintended regression introduced in #14953. Pre-PR the option was set here.
Replaces #20042
Fix #20044
Fix PowerShell/vscode-powershell#4668
/cc Andy Jordan (@andyleejordan) Jakub Jareš (@nohwnd)
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.(which runs in a different PS Host).