Skip to content

Test fixes which fail during release testing. #20028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
adityapatwardhan merged 1 commit into from
Jul 27, 2023
Merged

Test fixes which fail during release testing. #20028

adityapatwardhan merged 1 commit into from
Jul 27, 2023

Conversation

@JamesWTruher
Copy link
Collaborator

@JamesWTruher JamesWTruher commented Jul 26, 2023

A number of changes to reduce test failures during release test. Skip all tests for Send-MailMessage, this cmdlet is deprecated. Improve robustness for remove certificates in AfterAll. Check status of reply for test-connection before checking address.

PR Summary

PR Context

The only controversial change may be the skipping of tests for Send-MailMessage. Since this cmdlet is deprecated and unsupported, we probably don't need to test it. We still include it, and compliance checks will still occur, but functional tests may now be skipped. These tests are not consistent in our release tests and cause additional inspections when we do a release build.

PR Checklist

@JamesWTruher
Fixes for release tests.
b754c02 
A number of changes to reduce test failures during release test.
Skip all tests for Send-MailMessage, this cmdlet is deprecated.
Improve robustness for remove certificates in AfterAll.
Check status of reply for test-connection before checking address.
@pull-request-quantifier-deprecated
Copy link

pull-request-quantifier-deprecated bot commented Jul 26, 2023

This PR has 98 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!

Quantification details 

Label      : Small
Size       : +69 -29
Percentile : 39.2%

Total files changed: 5

Change summary by file extension:
.ps1 : +69 -29

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detected.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.

Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

TravisEz13
TravisEz13 reviewed Jul 27, 2023
View reviewed changes
Copy link
Member

@TravisEz13 TravisEz13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed all but tab completion

@adityapatwardhan adityapatwardhan merged commit 91447e6 into PowerShell:master Jul 27, 2023
@SeeminglyScience SeeminglyScience added the CL-Test Indicates that a PR should be marked as a test change in the Change Log label Aug 17, 2023
@JamesWTruher JamesWTruher deleted the ReleaseTestFix03 branch September 23, 2023 05:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TravisEz13 TravisEz13 TravisEz13 left review comments

@adityapatwardhan adityapatwardhan adityapatwardhan approved these changes

Assignees

@TravisEz13 TravisEz13

Labels

CL-Test Indicates that a PR should be marked as a test change in the Change Log Small

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@JamesWTruher @TravisEz13 @adityapatwardhan @SeeminglyScience