Repository navigation
Move build to .NET 8 preview 6 - #19991
Aditya Patwardhan (adityapatwardhan) merged 12 commits into
Conversation
0441695 to
895044a
Compare
Dismiss my review as more changes were pushed.
|
The Windows xunit test issue is a known issue with MMI.dll and .NET 8 newer previews. I believe Aditya Patwardhan (@adityapatwardhan) has a workaround. |
Travis Plunk (TravisEz13)
left a comment
There was a problem hiding this comment.
looked at changes
|
This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days. |
1 similar comment
|
This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days. |
b8f5653 to
3e8b88f
Compare
|
Steve Lee (@SteveL-MSFT) - please look at CI failures |
|
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
PR Summary
Errors were from additional method analysis that methods not using instance data should be marked as static. Addressed all the reported errors.
Constructor for a marshaled type has to be public due to breaking change in .NET 8.
Needed to rev isolation test module to use 13.0.0.1 of NewtonSoft as anything older gets flagged due to a security issue. Changed test to check file location instead of version.
Removed win-arm build as some assemblies for .NET 8 don't appear to be published for win-arm anymore since .NET dropped support for it.
PR Context
Moving to .NET 8 preview 6
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.(which runs in a different PS Host).