-
Notifications
You must be signed in to change notification settings - Fork 8.1k
Remove HostArchitecture dynamic for osxpkg #19917
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
|
Mark |
PR Summary
As of PR #19450
New-UnixPackage()takes a-HostArchitectureparam as it is needed to be passed toNew-FpmArgumentscalled in that method. Since-HostArchitectureis passed as a param (even for osxpkg) we don't need to also create a dynamic param called-HostArchitecturefor osxpkg type package.PR Context
Will fix build issue.
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.(which runs in a different PS Host).