Skip to content

Fix native executables not redirecting to file #19841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
SeeminglyScience wants to merge 6 commits into from
Closed

Fix native executables not redirecting to file #19841

SeeminglyScience wants to merge 6 commits into from

Conversation

@SeeminglyScience
Copy link
Collaborator

@SeeminglyScience SeeminglyScience commented Jun 22, 2023

PR Summary

Fixes #19836

PR Context

Because Out-File is no longer appended in the pipeline, the calculation for if stdout should be redirected was incorrect. Adding a check for StdOutDestination in that calculation fixed the issue.

PR Checklist

@SeeminglyScience SeeminglyScience mentioned this pull request Jun 22, 2023
Closed
5 tasks
daxian-dbw
daxian-dbw requested changes Jun 22, 2023
View reviewed changes
src/System.Management.Automation/engine/NativeCommandProcessor.cs
// cmd.exe /c "echo test" > somefile.log
// in that case we want to keep output redirection even though Out-Default is the only
// downstream command.
if (IsDownstreamOutDefault(this.commandRuntime.OutputPipe) && StdOutDestination is null)
Copy link
Member

@daxian-dbw daxian-dbw Jun 22, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we didn't have tests covering the stdout redirection scenarios. Can you please add tests?

@ghost ghost added the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Jun 22, 2023
@SeeminglyScience @daxian-dbw
Update src/System.Management.Automation/engine/NativeCommandProcessor.cs
7d2291e 
Co-authored-by: Dongbo Wang <dongbow@microsoft.com>
@ghost ghost removed the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Jun 22, 2023
@pull-request-quantifier-deprecated
Copy link

pull-request-quantifier-deprecated bot commented Jun 22, 2023

This PR has 7 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!

Quantification details 

Label      : Extra Small
Size       : +6 -1
Percentile : 2.8%

Total files changed: 2

Change summary by file extension:
.cs : +1 -1
.ps1 : +5 -0

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detected.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.

Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

@SeeminglyScience
Copy link
Collaborator Author

SeeminglyScience commented Jun 22, 2023

Eh I pulled something wrong, I'm gonna cherry pick the commits out and open a new PR

@SeeminglyScience SeeminglyScience mentioned this pull request Jun 22, 2023
Merged
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@daxian-dbw daxian-dbw daxian-dbw requested changes

Assignees

No one assigned

Labels

Extra Small

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Native pipeline fails to redirect stdout to files, always to console ( PSNativeCommandPreserveBytePipe enabled )

2 participants

@SeeminglyScience @daxian-dbw