-
Notifications
You must be signed in to change notification settings - Fork 8.1k
Rename file from PingPathCommand.cs to TestPathCommand.cs #19782
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename file from PingPathCommand.cs to TestPathCommand.cs #19782
Conversation
|
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
|
We lost git history if we renamed the file. |
|
Test-Path is not stable (in contrast with Invoke-Expression) so I think the history is important. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test-Path has been around since the beginning, so it's pretty stable now. I looked at the change history, and most of them are parts of big logistic changes, such as code cleanup on using directive and etc. So, I think it's okay to take this change.
|
🎉 Handy links: |
PR Summary
Renaming file from
PingPathCommand.cstoTestPathCommand.csto match cmdlet name better.PR Context
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.(which runs in a different PS Host).