-
Notifications
You must be signed in to change notification settings - Fork 8.1k
Add WDAC Audit logging 3 #19641
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add WDAC Audit logging 3 #19641
Conversation
…-Object.cs Co-authored-by: Dongbo Wang <dongbow@microsoft.com>
…-Object.cs Co-authored-by: Dongbo Wang <dongbow@microsoft.com>
Co-authored-by: Dongbo Wang <dongbow@microsoft.com>
…se.cs Co-authored-by: Dongbo Wang <dongbow@microsoft.com>
…se.cs Co-authored-by: Dongbo Wang <dongbow@microsoft.com>
…se.cs Co-authored-by: Dongbo Wang <dongbow@microsoft.com>
…nd.cs Co-authored-by: Dongbo Wang <dongbow@microsoft.com>
Co-authored-by: Dongbo Wang <dongbow@microsoft.com>
Co-authored-by: Dongbo Wang <dongbow@microsoft.com>
…se.cs Co-authored-by: Dongbo Wang <dongbow@microsoft.com>
Co-authored-by: Sean Wheeler <sean.wheeler@microsoft.com>
daxian-dbw
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me overall. Left a few more comments.
src/System.Management.Automation/engine/Modules/ModuleCmdletBase.cs
Outdated
Show resolved
Hide resolved
src/System.Management.Automation/engine/remoting/client/RunspaceRef.cs
Outdated
Show resolved
Hide resolved
src/System.Management.Automation/engine/runtime/Operations/MiscOps.cs
Outdated
Show resolved
Hide resolved
…cOps.cs Co-authored-by: Dongbo Wang <dongbow@microsoft.com>
…se.cs Co-authored-by: Dongbo Wang <dongbow@microsoft.com>
|
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
daxian-dbw
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks @PaulHigin for pushing this change through!
sdwheeler
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
🎉 Handy links: |
PR Summary
This PR adds WDAC audit logging using a different implementation from previous versions.
PR Context
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.(which runs in a different PS Host).