Skip to content

Change logic for testing missing or extra cmdlets. #19635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adityapatwardhan merged 2 commits into from
May 11, 2023
Merged

Change logic for testing missing or extra cmdlets. #19635

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5317e38
Change logic for testing missing or extra cmdlets.
JamesWTruher May 9, 2023
9eda95f
Use -HaveCount rather than getting the count directly.
JamesWTruher May 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions test/powershell/engine/Basic/DefaultCommands.Tests.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -613,9 +613,12 @@ Describe "Verify aliases and cmdlets" -Tags "CI" {
}

It "All approved Cmdlets present (no new Cmdlets added, no Cmdlets removed)" {
$observedCmdletNames = $currentCmdletList.ForEach({"{0}" -f $_.Name}) | Sort-Object
$expectedCmdletNames = $commandHashTableList.ForEach({"{0}" -f $_.Name}) | Sort-Object
$observedCmdletNames | Should -Be $expectedCmdletNames
$observedCmdletNames = $currentCmdletList.ForEach({"{0}" -f $_.Name})
$expectedCmdletNames = $commandHashTableList.ForEach({"{0}" -f $_.Name})
$extraCmds = $observedCmdletNames.Where({$expectedCmdletNames -notcontains $_})
$missedCmds = $expectedCmdletNames.Where({$observedCmdletNames -notcontains $_})
$extraCmds | Should -HaveCount 0 -Because "Extra cmdlets $($extraCmds -join ',')"
$missedCmds | Should -HaveCount 0 -Because "Missed cmdlets $($missedCmds -join ',')"
}

It "'<Name>' Cmdlet should have the correct ConfirmImpact '<ConfirmImpact>'" -TestCases $commandHashtableList {
Expand Down