Update JsonSchema.Net version #19610

gregsdennis · 2023-05-04T04:34:13Z

PR Summary

Follow-up to #18141. Updates JsonSchema.Net to latest version: v3.3.2 -> v4.1.0.

Release notes can be viewed here.

PR Context

While not strictly required now, this PR sets up for later updates that will incorporate additional support for JSON Schema.

PR Checklist

gregsdennis · 2023-05-04T04:37:37Z

src/Microsoft.PowerShell.Commands.Utility/resources/TestJsonCmdletStrings.resx

    <value>Cannot parse the JSON.</value>
  </data>
  <data name="InvalidJsonAgainstSchemaDetailed" xml:space="preserve">
-    <value>The JSON is not valid with the schema: {0} at {1}</value>


When I updated, I tested this locally with a schema & instance that had a problem at the root. The error that's output just ends with "at", and the fact that there's an empty JSON Pointer indicating the root object isn't conveyed. I think the quotes help.

src/Microsoft.PowerShell.Commands.Utility/commands/utility/TestJsonCommand.cs

gregsdennis · 2023-05-04T04:55:41Z

Looking into test failures...

Edit: I know what the problem is. I can update tomorrow.

gregsdennis · 2023-05-04T21:06:43Z

Actually, I'm not sure what's going on. I think it may have something to do with running in Linux, but I can't be sure. Everything works in Windows and in WSL.

Windows:

WSL:

This is without further changes.

Note: I'm leaving on business tomorrow for a little over a week, so this PR may need to sit for a while.

gregsdennis · 2023-05-04T22:20:59Z

@daxian-dbw would you mind if I put some temporary Console.WriteLine()s in the code to get some debugging info from the server test runner? I'll remove them once I get it working.

daxian-dbw · 2023-05-04T22:23:09Z

@gregsdennis Please feel free to add debugging messages in the code or test.

iSazonov · 2023-05-05T07:25:48Z

@gregsdennis Perhaps it is Unix line end chars?

gregsdennis · 2023-05-05T07:33:21Z

No, it's having trouble finding the files (resolving $ref). I'm debugging in #19617.

gregsdennis · 2023-05-05T22:04:51Z

Okay. That looks good. Now I just need to figure out this packaging stuff.

@iSazonov I think you just fixed this for me before, but I don't know what you did. I'm happy to learn. Is there any documentation on it? The error just says,

Please update D:\a\1\PowerShell\tools\packaging\Boms\windows.json per the above instructions

but there are no instructions. I assume they're in the code somewhere?

daxian-dbw · 2023-05-05T22:25:52Z

Hi @gregsdennis, thanks for finding the root cause and fix the issue!
For the packaging failure, please do the following:

click the "View more details on Azure Pipelines" of the "PowerShell-Windows-Packaging-CI" job
click on the "4 published; 1 consumed" in the "Related" tab
download the 1z5wd3xl.nu4-windows-fyiwyr3s.zry-bom.json file, and then in your working branch, replace the PowerShell\tools\packaging\Boms\windows.json file with it (make sure use the same windows.json name).
commit and push the change.

gregsdennis · 2023-05-05T23:22:56Z

Thanks, @daxian-dbw, I don't think I could have found that on my own.

Weird. It looks like nuget is packaging my Spanish language pack now. I'll have to look into that.

I had to update VS at some point in this process, and then I published a new version of the package.

pull-request-quantifier-deprecated · 2023-05-05T23:25:27Z

This PR has 34 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!

Quantification details

Label      : Extra Small
Size       : +18 -16
Percentile : 13.6%

Total files changed: 4

Change summary by file extension:
.csproj : +1 -1
.cs : +14 -14
.resx : +1 -1
.json : +2 -0

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

Fast and predictable releases to production:
- Optimal size changes are more likely to be reviewed faster with fewer
  iterations.
- Similarity in low PR complexity drives similar review times.
Review quality is likely higher as complexity is lower:
- Bugs are more likely to be detected.
- Code inconsistencies are more likely to be detected.
Knowledge sharing is improved within the participants:
- Small portions can be assimilated better.
Better engineering practices are exercised:
- Solving big problems by dividing them in well contained, smaller problems.
- Exercising separation of concerns within the code changes.

What can I do to optimize my changes

Use the PullRequestQuantifier to quantify your PR accurately
- Create a context profile for your repo using the context generator
- Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
- Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
- Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
Change your engineering behaviors
- For PRs that fall outside of the desired spectrum, review the details and check if:
  - Your PR could be split in smaller, self-contained PRs instead
  - Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

One line was added: +1 -0
One line was deleted: +0 -1
One line was modified: +1 -1 (git diff doesn't know about modified, it will
interpret that line like one addition plus one deletion)
Change percentiles: Change characteristics (addition, deletion, modification)
of this PR in relation to all other PRs within the repository.

Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

gregsdennis · 2023-05-05T23:59:36Z

@daxian-dbw everything looks good from my side. Thanks for the help. Let me know if there's anything else you want me to change.

daxian-dbw

LGTM. Thanks @gregsdennis for your contribution!

src/Microsoft.PowerShell.Commands.Utility/commands/utility/TestJsonCommand.cs

gregsdennis · 2023-06-28T07:17:17Z

@daxian-dbw @iSazonov I see releases for 7.2/7.3 just went out and 7.4-preview is also available, but the release notes don't have anything about this.

Just curious when this change is planned to release. Thanks.

iSazonov · 2023-06-28T14:17:21Z

@gregsdennis The commit is not backported to 7.2/7.3. (And will not be). The commit will be in 7.4 Preview4.

gregsdennis · 2023-06-28T18:48:54Z

Thank you!

ghost · 2023-06-29T22:05:25Z

🎉v7.4.0-preview.4 has been released which incorporates this pull request.:tada:

Handy links:

Release Notes

gregsdennis added 3 commits May 4, 2023 16:26

Updated JsonSchema.Net to latest (major bump)

1fca2fa

reset unnecessary resx changes

0fe1c38

reset more unnecessary resx changes

44fdb3a

gregsdennis requested review from PaulHigin, TravisEz13, adityapatwardhan, anmenaga and daxian-dbw as code owners May 4, 2023 04:34

pull-request-quantifier-deprecated bot added the Extra Small label May 4, 2023

ghost assigned daxian-dbw May 4, 2023

gregsdennis commented May 4, 2023

View reviewed changes

iSazonov reviewed May 4, 2023

View reviewed changes

src/Microsoft.PowerShell.Commands.Utility/commands/utility/TestJsonCommand.cs Outdated Show resolved Hide resolved

specify type in var declaration where type is not obvious

df20cd4

daxian-dbw mentioned this pull request May 4, 2023

Bump JsonSchema.Net from 3.3.2 to 4.1.0 #19611

Closed

remove unused using and fix indention

695d0b7

gregsdennis mentioned this pull request May 5, 2023

Update jsonschemanet version testing #19617

Closed

gregsdennis changed the title ~~Update jsonschemanet version~~ Update JsonSchema.Net version May 5, 2023

update JsonSchema.Net to v4.1.1

05962bf

update windows packaging bom

8ad897b

daxian-dbw approved these changes May 6, 2023

View reviewed changes

iSazonov reviewed May 7, 2023

View reviewed changes

src/Microsoft.PowerShell.Commands.Utility/commands/utility/TestJsonCommand.cs Show resolved Hide resolved

daxian-dbw mentioned this pull request May 8, 2023

Bump JsonSchema.Net from 3.3.2 to 4.1.1 #19624

Closed

StevenBucher98 added the PowerShell-Docs not needed The PR was reviewed and doesn't appear to require a PowerShell Docs update label May 8, 2023

daxian-dbw merged commit 4b261ec into PowerShell:master May 8, 2023

daxian-dbw added the CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log label May 8, 2023

Update JsonSchema.Net version #19610

Update JsonSchema.Net version #19610

Uh oh!

Conversation

gregsdennis commented May 4, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Summary

PR Context

PR Checklist

Uh oh!

gregsdennis May 4, 2023

Choose a reason for hiding this comment

Uh oh!

Uh oh!

gregsdennis commented May 4, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gregsdennis commented May 4, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gregsdennis commented May 4, 2023

Uh oh!

daxian-dbw commented May 4, 2023

Uh oh!

iSazonov commented May 5, 2023

Uh oh!

gregsdennis commented May 5, 2023

Uh oh!

gregsdennis commented May 5, 2023

Uh oh!

daxian-dbw commented May 5, 2023

Uh oh!

gregsdennis commented May 5, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pull-request-quantifier-deprecated bot commented May 5, 2023

What can I do to optimize my changes

How to interpret the change counts in git diff output

Uh oh!

gregsdennis commented May 5, 2023

Uh oh!

daxian-dbw left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

gregsdennis commented Jun 28, 2023

Uh oh!

iSazonov commented Jun 28, 2023

Uh oh!

gregsdennis commented Jun 28, 2023

Uh oh!

ghost commented Jun 29, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

gregsdennis commented May 4, 2023 •

edited

Loading

gregsdennis commented May 4, 2023 •

edited

Loading

gregsdennis commented May 4, 2023 •

edited

Loading

gregsdennis commented May 5, 2023 •

edited

Loading