Skip to content

Add reference to PSResourceGet #19597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
adityapatwardhan merged 29 commits into from
Jun 16, 2023
Merged

Add reference to PSResourceGet #19597

adityapatwardhan merged 29 commits into from
Jun 16, 2023

Conversation

@alerickson
Copy link
Member

@alerickson alerickson commented May 2, 2023

PR Summary

Update the version of PowerShellGet shipped in PowerShell to '3.0.21-beta21' and update PowerShellGet tests to reference new v3 cmdlets.

PR Context

PR Checklist

@ghost ghost assigned daxian-dbw May 2, 2023
@daxian-dbw
Copy link
Member

daxian-dbw commented May 2, 2023

@alerickson @adityapatwardhan Does this PR supersede #19458?

@daxian-dbw daxian-dbw mentioned this pull request May 2, 2023
Closed
22 tasks
@alerickson
Copy link
Member Author

alerickson commented May 2, 2023

@daxian-dbw yes, it does, I forgot about @adityapatwardhan's PR but this does supersede it.

@daxian-dbw
Copy link
Member

daxian-dbw commented May 4, 2023

@alerickson Please look into the test failures. Also, is the PR ready for review?

@daxian-dbw daxian-dbw marked this pull request as draft May 8, 2023 14:01
@StevenBucher98 StevenBucher98 added the PowerShell-Docs needed The PR was reviewed and a PowerShell Docs update is needed label May 8, 2023
@ghost ghost added the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label May 11, 2023
@ghost ghost added the Stale label May 26, 2023
@ghost
Copy link

ghost commented May 26, 2023

This pull request has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 15 days. It will be closed if no further activity occurs within 10 days of this comment.

@ghost ghost closed this Jun 6, 2023
@daxian-dbw daxian-dbw reopened this Jun 7, 2023
@ghost ghost removed the Stale label Jun 7, 2023
@alerickson alerickson marked this pull request as ready for review June 7, 2023 23:56
@alerickson alerickson changed the title Add reference to PSResourceGet WIP: Add reference to PSResourceGet Jun 9, 2023
@alerickson alerickson changed the title WIP: Add reference to PSResourceGet Add reference to PSResourceGet Jun 15, 2023
TravisEz13
TravisEz13 reviewed Jun 16, 2023
View reviewed changes
tools/packaging/boms/windows.json Outdated
Comment on lines 3432 to 3444
"FileType": "Product"
},
{
"Pattern": "Modules/Microsoft.PowerShell.PSResourceGet/Microsoft.PowerShell.PSResourceGet.dll",
"FileType": "Product"
},
{
"Pattern": "Modules/Microsoft.PowerShell.PSResourceGet/Microsoft.PowerShell.PSResourceGet.psd1",
"FileType": "Product"
},
{
"Pattern": "Modules/Microsoft.PowerShell.PSResourceGet/PSGet.Format.ps1xml",
"FileType": "Product"
Copy link
Member

@TravisEz13 TravisEz13 Jun 16, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Product in this context, means that Powershell should be signing them. From PowerShell's point of view, these are non-product files.

Copy link
Member Author

@alerickson alerickson Jun 16, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TravisEz13 just updated, do the linux and mac boms look good?

Copy link
Member

@TravisEz13 TravisEz13 Jun 16, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

linux and mac boms aren't used. Don't worry about them.

@pull-request-quantifier-deprecated
Copy link

pull-request-quantifier-deprecated bot commented Jun 16, 2023

This PR has 166 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!

Quantification details 

Label      : Medium
Size       : +161 -5
Percentile : 53.2%

Total files changed: 6

Change summary by file extension:
.csproj : +1 -0
.ps1 : +116 -5
.json : +44 -0

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detected.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.

Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

@adityapatwardhan adityapatwardhan merged commit c43becc into PowerShell:master Jun 16, 2023
@adityapatwardhan adityapatwardhan added the CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log label Jun 28, 2023
@ghost
Copy link

ghost commented Jun 29, 2023

🎉v7.4.0-preview.4 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TravisEz13 TravisEz13 TravisEz13 approved these changes

@adityapatwardhan adityapatwardhan adityapatwardhan approved these changes

@daxian-dbw daxian-dbw Awaiting requested review from daxian-dbw

@anmenaga anmenaga Awaiting requested review from anmenaga

@PaulHigin PaulHigin Awaiting requested review from PaulHigin

Assignees

@daxian-dbw daxian-dbw

Labels

CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log Medium PowerShell-Docs needed The PR was reviewed and a PowerShell Docs update is needed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@alerickson @daxian-dbw @TravisEz13 @adityapatwardhan @StevenBucher98