Skip to content

Fix incorrect string to type conversion #19560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
iSazonov merged 4 commits into from
May 31, 2023
Merged

Fix incorrect string to type conversion #19560

iSazonov merged 4 commits into from
May 31, 2023

Conversation

@MartinGC94
Copy link
Contributor

@MartinGC94 MartinGC94 commented Apr 24, 2023

PR Summary

Fixes incorrect string to type conversions like: [Type] 'int]whatever' so they are no longer parsed as types.
This was fixed by adding a check for ScanType to also check that the parsed type name matches the input type name.

PR Context

Fixes #19559

PR Checklist

@MartinGC94 MartinGC94 requested a review from daxian-dbw as a code owner April 24, 2023 15:52
@ghost ghost assigned iSazonov Apr 24, 2023
@daxian-dbw daxian-dbw added CL-Engine Indicates that a PR should be marked as an engine change in the Change Log Needs-Triage The issue is new and needs to be triaged by a work group. labels May 1, 2023
@StevenBucher98 StevenBucher98 added the PowerShell-Docs not needed The PR was reviewed and doesn't appear to require a PowerShell Docs update label May 8, 2023
@SteveL-MSFT SteveL-MSFT added the CommunityDay-Small A small PR that the PS team has identified to prioritize to review label May 15, 2023
andyleejordan
andyleejordan approved these changes May 22, 2023
View reviewed changes
Copy link
Member

@andyleejordan andyleejordan left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good fix! Though @SeeminglyScience do you think it should error instead of returning null? I'm unsure what's more correct.

andyleejordan
andyleejordan requested changes May 22, 2023
View reviewed changes
Copy link
Member

@andyleejordan andyleejordan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New suggestion of a test using the left-hand side operator (which should throw now like with other errors, and I don't if it will).

@ghost ghost added the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label May 22, 2023
@MartinGC94 @andyleejordan
Apply suggestions from code review
ff978ef 
Co-authored-by: Andy Jordan <2226434+andschwa@users.noreply.github.com>
@ghost ghost removed the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label May 25, 2023
@pull-request-quantifier-deprecated
Copy link

pull-request-quantifier-deprecated bot commented May 29, 2023

This PR has 5 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!

Quantification details 

Label      : Extra Small
Size       : +4 -1
Percentile : 2%

Total files changed: 2

Change summary by file extension:
.cs : +1 -1
.ps1 : +3 -0

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detected.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.

Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

andyleejordan
andyleejordan approved these changes May 30, 2023
View reviewed changes
Copy link
Member

@andyleejordan andyleejordan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I guess it needed braces 💁

@iSazonov iSazonov merged commit 31dd648 into PowerShell:master May 31, 2023
xavierlmendez added a commit to xavierlmendez/PowerShell that referenced this pull request May 31, 2023
@xavierlmendez
Merge pull request #1 from PowerShell/master
fae58fd 
Fix incorrect string to type conversion (PowerShell#19560)
@daxian-dbw daxian-dbw removed the Needs-Triage The issue is new and needs to be triaged by a work group. label Jun 4, 2023
@ghost
Copy link

ghost commented Jun 29, 2023

🎉v7.4.0-preview.4 has been released which incorporates this pull request.:tada:

Handy links:

@ghost ghost mentioned this pull request Jun 29, 2023
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iSazonov iSazonov iSazonov left review comments

@andyleejordan andyleejordan andyleejordan approved these changes

@daxian-dbw daxian-dbw Awaiting requested review from daxian-dbw daxian-dbw is a code owner

Assignees

@iSazonov iSazonov

Labels

CL-Engine Indicates that a PR should be marked as an engine change in the Change Log CommunityDay-Small A small PR that the PS team has identified to prioritize to review Extra Small PowerShell-Docs not needed The PR was reviewed and doesn't appear to require a PowerShell Docs update

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[type] cast and -as [Type] malfunction with strings that contain "]" (only)

6 participants

@MartinGC94 @andyleejordan @iSazonov @daxian-dbw @SteveL-MSFT @StevenBucher98